linux-kernel - Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7f1660f4-63bd-8f24-4c7a-4b92f0d38e16@collabora.com>
Date:   Tue, 17 May 2022 15:43:44 +0200
From:   AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>
To:     Matthias Brugger <matthias.bgg@...il.com>, robh+dt@...nel.org
Cc:     krzysztof.kozlowski+dt@...aro.org, sboyd@...nel.org,
        chun-jie.chen@...iatek.com, rex-bc.chen@...iatek.com,
        wenst@...omium.org, devicetree@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/6] dt-bindings: arm: MediaTek: Fix clock bindings

Il 17/05/22 15:39, Matthias Brugger ha scritto:
> 
> 
> On 17/05/2022 12:15, AngeloGioacchino Del Regno wrote:
>> As per Rob Herring's review [1] on my mt6795 clocks bindings patches, for
>> which I've used the already upstreamed ones as a base, it was found that
>> these bindings have some issues.
>> This series is addressing the issues that were found by Rob on my series,
>> which are present on all of the already merged bindings.
>>
>> [1]: 
>> https://patchwork.kernel.org/project/linux-mediatek/patch/20220513165050.500831-5-angelogioacchino.delregno@collabora.com/#24859953 
>>
> 
> I would say we could squash patches here and make it 3 instead of 6.
> In any case for the whole series:
> 
> Reviewed-by: Matthias Brugger <matthias.bgg@...il.com>
> 

I had the same initial idea, but chose to do it in 6 patches because otherwise
the titles would be too generic and not really effectual in the end...

If anyone wants them squashed, now you know what was my difficulty and my
reasons :-)

By the way, thank you!

>>
>> AngeloGioacchino Del Regno (6):
>>    dt-bindings: arm: mt8186-clock: Remove unnecessary 'items' and fix
>>      formatting
>>    dt-bindings: arm: mt8186: Set #clock-cells as required property
>>    dt-bindings: arm: mt8195-clock: Remove unnecessary 'items' and fix
>>      formatting
>>    dt-bindings: arm: mt8195: Set #clock-cells as required property
>>    dt-bindings: arm: mt8192-clock: Remove unnecessary 'items'
>>    dt-bindings: arm: mt8192: Set #clock-cells as required property
>>
>>   .../arm/mediatek/mediatek,mt8186-clock.yaml   | 29 ++++-----
>>   .../mediatek/mediatek,mt8186-sys-clock.yaml   |  1 +
>>   .../arm/mediatek/mediatek,mt8192-clock.yaml   | 46 +++++++--------
>>   .../mediatek/mediatek,mt8192-sys-clock.yaml   |  1 +
>>   .../arm/mediatek/mediatek,mt8195-clock.yaml   | 59 ++++++++++---------
>>   .../mediatek/mediatek,mt8195-sys-clock.yaml   |  1 +
>>   6 files changed, 71 insertions(+), 66 deletions(-)
>>