lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 May 2022 19:21:47 +0530 From: Vihas Makwana <makvihas@...il.com> To: Pavel Skripkin <paskripkin@...il.com> Cc: Larry Finger <Larry.Finger@...inger.net>, Phillip Potter <phil@...lpotter.co.uk>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Michael Straube <straube.linux@...il.com>, linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org, Dan Carpenter <dan.carpenter@...cle.com> Subject: Re: [PATCH 2/3] staging: r8188eu: fix checkpatch.pl warnings in rtw_pwrctrl On Tue, May 17, 2022 at 1:15 AM Pavel Skripkin <paskripkin@...il.com> wrote: > > Hi Vihas, > > On 5/16/22 20:03, Vihas Makwana wrote: > > Refactor the code to fix following warnings: > > WARNING: Comparisons should place the constant on the right side of the test > > > > Signed-off-by: Vihas Makwana <makvihas@...il.com> > > --- > > [code snip] > > > if ((pwrpriv->smart_ps == smart_ps) && > > @@ -356,7 +356,7 @@ void rtw_init_pwrctrl_priv(struct adapter *padapter) > > > > pwrctrlpriv->LpsIdleCount = 0; > > pwrctrlpriv->power_mgnt = padapter->registrypriv.power_mgnt;/* PS_MODE_MIN; */ > > - pwrctrlpriv->bLeisurePs = PS_MODE_ACTIVE != pwrctrlpriv->power_mgnt; > > + pwrctrlpriv->bLeisurePs = pwrctrlpriv->power_mgnt != PS_MODE_ACTIVE; > > > > Please remove extra space > Oh sorry, my bad. Will submit a v2. > > > With regards, > Pavel Skripkin -- Thanks, Vihas
Powered by blists - more mailing lists