lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 May 2022 10:08:57 -0400 From: Jeff Layton <jlayton@...nel.org> To: Colin Ian King <colin.i.king@...il.com>, Xiubo Li <xiubli@...hat.com>, Ilya Dryomov <idryomov@...il.com>, ceph-devel@...r.kernel.org Cc: kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] ceph: remove redundant variable ino On Wed, 2022-05-18 at 09:55 +0100, Colin Ian King wrote: > Variable ino is being assigned a value that is never read. The variable > and assignment are redundant, remove it. > > Cleans up clang scan build warning: > warning: Although the value stored to 'ino' is used in the enclosing > expression, the value is never actually read from 'ino' > [deadcode.DeadStores] > > Signed-off-by: Colin Ian King <colin.i.king@...il.com> > --- > fs/ceph/mds_client.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fs/ceph/mds_client.c b/fs/ceph/mds_client.c > index 00c3de177dd6..20197f05faec 100644 > --- a/fs/ceph/mds_client.c > +++ b/fs/ceph/mds_client.c > @@ -437,7 +437,7 @@ static int ceph_parse_deleg_inos(void **p, void *end, > ceph_decode_32_safe(p, end, sets, bad); > dout("got %u sets of delegated inodes\n", sets); > while (sets--) { > - u64 start, len, ino; > + u64 start, len; > > ceph_decode_64_safe(p, end, start, bad); > ceph_decode_64_safe(p, end, len, bad); > @@ -449,7 +449,7 @@ static int ceph_parse_deleg_inos(void **p, void *end, > continue; > } > while (len--) { > - int err = xa_insert(&s->s_delegated_inos, ino = start++, > + int err = xa_insert(&s->s_delegated_inos, start++, > DELEGATED_INO_AVAILABLE, > GFP_KERNEL); > if (!err) { Reviewed-by: Jeff Layton <jlayton@...nel.org>
Powered by blists - more mailing lists