linux-kernel - Re: [v7] FROMLIST: ASoC: Intel: sof_cs42l42: adding support for ADL configuration and BT offload audio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <728c697b-0df7-3d95-10cb-ce0111f0017b@linux.intel.com>
Date:   Wed, 18 May 2022 08:32:17 -0500
From:   Pierre-Louis Bossart <pierre-louis.bossart@...ux.intel.com>
To:     Terry Chen <terry_chen@...tron.corp-partner.google.com>,
        alsa-devel@...a-project.org
Cc:     cezary.rojewski@...el.com, liam.r.girdwood@...ux.intel.com,
        yang.jie@...ux.intel.com, broonie@...nel.org, perex@...ex.cz,
        tiwai@...e.com, brent.lu@...el.com, cujomalainey@...omium.org,
        seanpaul@...omium.org, casey.g.bowman@...el.com,
        mark_hsieh@...tron.corp-partner.google.com,
        vamshi.krishna.gopal@...el.com, mac.chiang@...el.com,
        kai.vehmanen@...ux.intel.com, linux-kernel@...r.kernel.org
Subject: Re: [v7] FROMLIST: ASoC: Intel: sof_cs42l42: adding support for ADL
 configuration and BT offload audio


> +	{
> +		.id = "10134242",
> +		.drv_name = "adl_mx98360a_cs4242",
> +		.machine_quirk = snd_soc_acpi_codec_list,
> +		.quirk_data = &adl_max98360a_amp,
> +		.sof_tplg_filename = "sof-adl-max98360a-rt5682.tplg",
> +	},

To repeat myself, there is no precedent for using a topology file name
that refers to a codec from a different vendor used on a different
platform.

It may work but it's confusing and not maintainable. I don't want to
start a trend where confusion becomes the norm.

In previous contributions, platforms with Cirrus Logic chips used a
non-ambiguous filename, please follow this example:

	{
		.id = "CSC3541",
		.drv_name = "adl_cs35l41",
		.sof_tplg_filename = "sof-adl-cs35l41.tplg",
	},

and use

.sof_tplg_filename = "sof-adl-max98360a-cs42l42.tplg",