linux-kernel - Re: [PATCH -next] fuse: return the more nuanced writeback error on close()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <YoUIDcOmfJ5lppu3@zeniv-ca.linux.org.uk>
Date:   Wed, 18 May 2022 14:51:57 +0000
From:   Al Viro <viro@...iv.linux.org.uk>
To:     ChenXiaoSong <chenxiaosong2@...wei.com>
Cc:     miklos@...redi.hu, linux-fsdevel@...r.kernel.org,
        linux-kernel@...r.kernel.org, liuyongqiang13@...wei.com,
        yi.zhang@...wei.com, zhangxiaoxu5@...wei.com
Subject: Re: [PATCH -next] fuse: return the more nuanced writeback error on
 close()

On Wed, May 18, 2022 at 10:57:29PM +0800, ChenXiaoSong wrote:

> +	/* return more nuanced writeback errors */
>  	if (err)
> -		return err;
> +		return filemap_check_wb_err(file->f_mapping, 0);
>  
>  	err = 0;

As an aside, what the hell is that err = 0 about?  Before or after
that patch, that is - "let's make err zero, in case it had somehow
magically changed ceased to be so since if (err) bugger_off just above"?