linux-kernel - Re: [PATCH] f2fs: make f2fs_read_inline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 May 2022 23:23:51 +0800
From:   Chao Yu <chao@...nel.org>
To:     Chao Liu <liuchao@...lpad.com>, Jaegeuk Kim <jaegeuk@...nel.org>
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org, Yue Hu <huyue2@...lpad.com>,
        Wayne Zhang <zhangwen@...lpad.com>,
        Chao Liu <chaoliu719@...il.com>
Subject: Re: [PATCH] f2fs: make f2fs_read_inline_data() more readable

On 2022/5/18 10:33, Chao Liu wrote:
> In f2fs_read_inline_data(), it is confused with checking of
> inline_data flag, as we checked it before calling. So this
> patch add some comments for f2fs_has_inline_data().
> 
> Signed-off-by: Chao Liu

It looks email address is missing, but it shows after I can apply this
patch to my local git repo...

Could you please check your email client configuration?

Thanks,

> ---
> fs/f2fs/f2fs.h | 4 ++++
> 1 file changed, 4 insertions(+)
> 
> diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h
> index f579e2ed0f14..5071f6636e41 100644
> --- a/fs/f2fs/f2fs.h
> +++ b/fs/f2fs/f2fs.h
> @@ -3167,6 +3167,10 @@ static inline int inline_xattr_size(struct inode *inode)
> return 0;
> }
> 
> +/*
> + * Notice: check inline_data flag without inode page lock is unsafe.
> + * It could change at any time by f2fs_convert_inline_page().
> + */
> static inline int f2fs_has_inline_data(struct inode *inode)
> {
> return is_inode_flag_set(inode, FI_INLINE_DATA);
> -- 
> 2.25.1
>