linux-kernel - Re: [PATCH v2 1/3] x86/crash: Disable virt in core NMI crash handler to avoid double shootdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0a8918a-f4f9-d852-27be-52a095a9e59f@igalia.com>
Date:   Wed, 18 May 2022 12:50:10 -0300
From:   "Guilherme G. Piccoli" <gpiccoli@...lia.com>
To:     Sean Christopherson <seanjc@...gle.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org
Cc:     "H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org,
        Vitaly Kuznetsov <vkuznets@...hat.com>,
        Paolo Bonzini <pbonzini@...hat.com>
Subject: Re: [PATCH v2 1/3] x86/crash: Disable virt in core NMI crash handler
 to avoid double shootdown

On 17/05/2022 21:16, Sean Christopherson wrote:
> [...]
> Fixes: ed72736183c4 ("x86/reboot: Force all cpus to exit VMX root if VMX is supported)
> Cc: stable@...r.kernel.org
> Reported-by: Guilherme G. Piccoli <gpiccoli@...lia.com>
> Cc: Vitaly Kuznetsov <vkuznets@...hat.com>
> Cc: Paolo Bonzini <pbonzini@...hat.com>
> Link: https://lore.kernel.org/all/20220427224924.592546-2-gpiccoli@igalia.com
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>
> ---
>  arch/x86/include/asm/reboot.h |  1 +
>  arch/x86/kernel/crash.c       | 16 +--------
>  arch/x86/kernel/reboot.c      | 66 ++++++++++++++++++++++++++++-------
>  3 files changed, 56 insertions(+), 27 deletions(-)

Thanks Sean, great patch! It's working fine according to my tests, and
the comments made the code very clear.
Feel free to add:

Tested-by: Guilherme G. Piccoli <gpiccoli@...lia.com>