| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <202205190028.z15SPbJx-lkp@intel.com>
Date: Thu, 19 May 2022 00:55:45 +0800
From: kernel test robot <lkp@...el.com>
To: Sascha Hauer <s.hauer@...gutronix.de>,
linux-wireless@...r.kernel.org
Cc: kbuild-all@...ts.01.org, Neo Jou <neojou@...il.com>,
Hans Ulli Kroll <linux@...i-kroll.de>,
Ping-Ke Shih <pkshih@...ltek.com>,
Yan-Hsuan Chuang <tony0620emma@...il.com>,
Kalle Valo <kvalo@...nel.org>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Martin Blumenstingl <martin.blumenstingl@...glemail.com>,
kernel@...gutronix.de, Johannes Berg <johannes@...solutions.net>,
Sascha Hauer <s.hauer@...gutronix.de>
Subject: Re: [PATCH 07/10] rtw88: Add rtw8723du chipset support
Hi Sascha,
I love your patch! Perhaps something to improve:
[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main v5.18-rc7 next-20220518]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]
url: https://github.com/intel-lab-lkp/linux/commits/Sascha-Hauer/RTW88-Add-support-for-USB-variants/20220518-162621
base: https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220519/202205190028.z15SPbJx-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/0a06adba364ef264404e3c7ae111a71f0d74c5a9
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Sascha-Hauer/RTW88-Add-support-for-USB-variants/20220518-162621
git checkout 0a06adba364ef264404e3c7ae111a71f0d74c5a9
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/net/wireless/realtek/rtw88/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
>> drivers/net/wireless/realtek/rtw88/util.c:119:6: warning: no previous prototype for 'rtw_collect_sta_iter' [-Wmissing-prototypes]
119 | void rtw_collect_sta_iter(void *data, struct ieee80211_sta *sta)
| ^~~~~~~~~~~~~~~~~~~~
>> drivers/net/wireless/realtek/rtw88/util.c:165:6: warning: no previous prototype for 'rtw_collect_vif_iter' [-Wmissing-prototypes]
165 | void rtw_collect_vif_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
| ^~~~~~~~~~~~~~~~~~~~
vim +/rtw_collect_sta_iter +119 drivers/net/wireless/realtek/rtw88/util.c
1c99f6652d3fbb Sascha Hauer 2022-05-18 118
1c99f6652d3fbb Sascha Hauer 2022-05-18 @119 void rtw_collect_sta_iter(void *data, struct ieee80211_sta *sta)
1c99f6652d3fbb Sascha Hauer 2022-05-18 120 {
1c99f6652d3fbb Sascha Hauer 2022-05-18 121 struct rtw_iter_stas_data *iter_stas = data;
1c99f6652d3fbb Sascha Hauer 2022-05-18 122 struct rtw_stas_entry *stas_entry;
1c99f6652d3fbb Sascha Hauer 2022-05-18 123
1c99f6652d3fbb Sascha Hauer 2022-05-18 124 stas_entry = kmalloc(sizeof(*stas_entry), GFP_ATOMIC);
1c99f6652d3fbb Sascha Hauer 2022-05-18 125 if (!stas_entry)
1c99f6652d3fbb Sascha Hauer 2022-05-18 126 return;
1c99f6652d3fbb Sascha Hauer 2022-05-18 127
1c99f6652d3fbb Sascha Hauer 2022-05-18 128 stas_entry->sta = sta;
1c99f6652d3fbb Sascha Hauer 2022-05-18 129 list_add_tail(&stas_entry->list, &iter_stas->list);
1c99f6652d3fbb Sascha Hauer 2022-05-18 130 }
1c99f6652d3fbb Sascha Hauer 2022-05-18 131
1c99f6652d3fbb Sascha Hauer 2022-05-18 132 void rtw_iterate_stas(struct rtw_dev *rtwdev,
1c99f6652d3fbb Sascha Hauer 2022-05-18 133 void (*iterator)(void *data,
1c99f6652d3fbb Sascha Hauer 2022-05-18 134 struct ieee80211_sta *sta),
1c99f6652d3fbb Sascha Hauer 2022-05-18 135 void *data)
1c99f6652d3fbb Sascha Hauer 2022-05-18 136 {
1c99f6652d3fbb Sascha Hauer 2022-05-18 137 struct rtw_iter_stas_data iter_data;
1c99f6652d3fbb Sascha Hauer 2022-05-18 138 struct rtw_stas_entry *sta_entry, *tmp;
1c99f6652d3fbb Sascha Hauer 2022-05-18 139
1c99f6652d3fbb Sascha Hauer 2022-05-18 140 iter_data.rtwdev = rtwdev;
1c99f6652d3fbb Sascha Hauer 2022-05-18 141 INIT_LIST_HEAD(&iter_data.list);
1c99f6652d3fbb Sascha Hauer 2022-05-18 142
1c99f6652d3fbb Sascha Hauer 2022-05-18 143 ieee80211_iterate_stations_atomic(rtwdev->hw, rtw_collect_sta_iter,
1c99f6652d3fbb Sascha Hauer 2022-05-18 144 &iter_data);
1c99f6652d3fbb Sascha Hauer 2022-05-18 145
1c99f6652d3fbb Sascha Hauer 2022-05-18 146 list_for_each_entry_safe(sta_entry, tmp, &iter_data.list,
1c99f6652d3fbb Sascha Hauer 2022-05-18 147 list) {
1c99f6652d3fbb Sascha Hauer 2022-05-18 148 list_del_init(&sta_entry->list);
1c99f6652d3fbb Sascha Hauer 2022-05-18 149 iterator(data, sta_entry->sta);
1c99f6652d3fbb Sascha Hauer 2022-05-18 150 kfree(sta_entry);
1c99f6652d3fbb Sascha Hauer 2022-05-18 151 }
1c99f6652d3fbb Sascha Hauer 2022-05-18 152 }
1c99f6652d3fbb Sascha Hauer 2022-05-18 153
1c99f6652d3fbb Sascha Hauer 2022-05-18 154 struct rtw_vifs_entry {
1c99f6652d3fbb Sascha Hauer 2022-05-18 155 struct list_head list;
1c99f6652d3fbb Sascha Hauer 2022-05-18 156 struct ieee80211_vif *vif;
1c99f6652d3fbb Sascha Hauer 2022-05-18 157 u8 mac[ETH_ALEN];
1c99f6652d3fbb Sascha Hauer 2022-05-18 158 };
1c99f6652d3fbb Sascha Hauer 2022-05-18 159
1c99f6652d3fbb Sascha Hauer 2022-05-18 160 struct rtw_iter_vifs_data {
1c99f6652d3fbb Sascha Hauer 2022-05-18 161 struct rtw_dev *rtwdev;
1c99f6652d3fbb Sascha Hauer 2022-05-18 162 struct list_head list;
1c99f6652d3fbb Sascha Hauer 2022-05-18 163 };
1c99f6652d3fbb Sascha Hauer 2022-05-18 164
1c99f6652d3fbb Sascha Hauer 2022-05-18 @165 void rtw_collect_vif_iter(void *data, u8 *mac, struct ieee80211_vif *vif)
1c99f6652d3fbb Sascha Hauer 2022-05-18 166 {
1c99f6652d3fbb Sascha Hauer 2022-05-18 167 struct rtw_iter_vifs_data *iter_stas = data;
1c99f6652d3fbb Sascha Hauer 2022-05-18 168 struct rtw_vifs_entry *vifs_entry;
1c99f6652d3fbb Sascha Hauer 2022-05-18 169
1c99f6652d3fbb Sascha Hauer 2022-05-18 170 vifs_entry = kmalloc(sizeof(*vifs_entry), GFP_ATOMIC);
1c99f6652d3fbb Sascha Hauer 2022-05-18 171 if (!vifs_entry)
1c99f6652d3fbb Sascha Hauer 2022-05-18 172 return;
1c99f6652d3fbb Sascha Hauer 2022-05-18 173
1c99f6652d3fbb Sascha Hauer 2022-05-18 174 vifs_entry->vif = vif;
1c99f6652d3fbb Sascha Hauer 2022-05-18 175 ether_addr_copy(vifs_entry->mac, mac);
1c99f6652d3fbb Sascha Hauer 2022-05-18 176 list_add_tail(&vifs_entry->list, &iter_stas->list);
1c99f6652d3fbb Sascha Hauer 2022-05-18 177 }
1c99f6652d3fbb Sascha Hauer 2022-05-18 178
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists