[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <38e1f139-6814-db63-1f4b-5a76a1ab0eda@linaro.org>
Date: Wed, 18 May 2022 20:31:00 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
To: Kuogee Hsieh <quic_khsieh@...cinc.com>
Cc: dri-devel@...ts.freedesktop.org, robdclark@...il.com,
sean@...rly.run, swboyd@...omium.org, dianders@...omium.org,
vkoul@...nel.org, daniel@...ll.ch, airlied@...ux.ie,
agross@...nel.org, bjorn.andersson@...aro.org,
quic_abhinavk@...cinc.com, quic_aravindh@...cinc.com,
quic_sbillaka@...cinc.com, freedreno@...ts.freedesktop.org,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 0/2] eDP/DP Phy vdda realted function
On 18/05/2022 20:29, Kuogee Hsieh wrote:
>
> On 5/18/2022 10:16 AM, Dmitry Baryshkov wrote:
>> On Wed, 18 May 2022 at 19:43, Kuogee Hsieh <quic_khsieh@...cinc.com>
>> wrote:
>>> 1) add regulator_set_load() to eDP/DP phy
>>> 2) remove vdda related function out of eDP/DP controller
>> These patches touch two subsystems and have a dependency between them.
>> How do we merge them?
>
> currently, both phy and controller are vote for regulator. The last vote
> will just increase count.
>
> Therefore the dependency should be very loose.
So, do you propose to merge dp change a cycle after the phy changes go in?
>
>
>>> Kuogee Hsieh (2):
>>> phy/qcom: add regulator_set_load to edp/dp phy
>>> drm/msm/dp: delete vdda regulator related functions from eDP/DP
>>> controller
>>>
>>> drivers/gpu/drm/msm/dp/dp_parser.c | 14 ------
>>> drivers/gpu/drm/msm/dp/dp_parser.h | 6 ---
>>> drivers/gpu/drm/msm/dp/dp_power.c | 95
>>> +------------------------------------
>>> drivers/phy/qualcomm/phy-qcom-edp.c | 25 ++++++++--
>>> drivers/phy/qualcomm/phy-qcom-qmp.c | 13 +++++
>>> 5 files changed, 36 insertions(+), 117 deletions(-)
>>>
>>> --
>>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>>> Forum,
>>> a Linux Foundation Collaborative Project
>>>
>>
--
With best wishes
Dmitry
Powered by blists - more mailing lists