linux-kernel - Re: [PATCH -next 2/3] [media] dm644x_ccdc: remove unnecessary check of res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+V-a8vkwVKQ4fR4hOfbh6UgaN8=0oZL-hKEpm3iTtO2=k7U_Q@mail.gmail.com>
Date:   Wed, 18 May 2022 20:42:33 +0100
From:   "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To:     Yang Yingliang <yangyingliang@...wei.com>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        linux-media <linux-media@...r.kernel.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>
Subject: Re: [PATCH -next 2/3] [media] dm644x_ccdc: remove unnecessary check
 of res

On Tue, Apr 26, 2022 at 3:53 AM Yang Yingliang <yangyingliang@...wei.com> wrote:
>
> The resource is checked in probe function, so there is
> no need do this check in remove function.
>
> Signed-off-by: Yang Yingliang <yangyingliang@...wei.com>
> ---
>  drivers/media/platform/ti/davinci/dm644x_ccdc.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
Reviewed-by: Lad Prabhakar <prabhakar.csengg@...il.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/ti/davinci/dm644x_ccdc.c b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> index c6378c4e0074..e4073e99914c 100644
> --- a/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> +++ b/drivers/media/platform/ti/davinci/dm644x_ccdc.c
> @@ -839,8 +839,7 @@ static int dm644x_ccdc_remove(struct platform_device *pdev)
>
>         iounmap(ccdc_cfg.base_addr);
>         res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -       if (res)
> -               release_mem_region(res->start, resource_size(res));
> +       release_mem_region(res->start, resource_size(res));
>         vpfe_unregister_ccdc_device(&ccdc_hw_dev);
>         return 0;
>  }
> --
> 2.25.1
>