linux-kernel - Re: [PATCH V5 0/3] Add unit test module for AMD P-State driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <bafe3aab-166d-7d9f-8909-8ffa41579a47@linuxfoundation.org>
Date:   Wed, 18 May 2022 14:02:38 -0600
From:   Shuah Khan <skhan@...uxfoundation.org>
To:     Huang Rui <ray.huang@....com>
Cc:     "Meng, Li (Jassmine)" <Li.Meng@....com>,
        "linux-pm@...r.kernel.org" <linux-pm@...r.kernel.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        "Fontenot, Nathan" <Nathan.Fontenot@....com>,
        "Sharma, Deepak" <Deepak.Sharma@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Limonciello, Mario" <Mario.Limonciello@....com>,
        "Su, Jinzhou (Joe)" <Jinzhou.Su@....com>,
        "Yuan, Perry" <Perry.Yuan@....com>,
        "Du, Xiaojian" <Xiaojian.Du@....com>,
        Viresh Kumar <viresh.kumar@...aro.org>,
        Borislav Petkov <bp@...en8.de>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH V5 0/3] Add unit test module for AMD P-State driver

On 5/17/22 11:19 PM, Huang Rui wrote:
> On Wed, May 18, 2022 at 04:03:05AM +0800, Shuah Khan wrote:

>> I reviewed the patches and the test driver amd-pstate-ut doesn't belong under
>> selftests. I would recommend the following approach:
>>
>> - add this test driver under drivers/cpufreq
>>
>> - KUnit is a better fit for this unit test driver unless you want
>>     to be able to run this without KUnit configured
>>
>> - add the test script under selftests - the script then can load the
>>     test driver and run tests and unload the driver.
>>
> 
> Thanks Shuah. We would like to introduce more CPU benchmark testing based
> the amd-pstate-ut next step, it may not be all the stuff in the kernel
> module. E.X.  use the script to trigger the tbench, gitsource, kernbench,
> netperf, speedometer, and etc. testing and monitor the cpu frequency and
> performance goals change, power consumption at runtime. Can the KUnit +
> Kselftests work more straight forward in user scenario?
> 

I am not sure if I understand your question. Also I am not sure if understand
the scope of the testing you are intending to do using amd-pstate-ut.

tbench, gitsource etc. are external tests (meaning not in kernel repo). Do these
tests depend on amd-pstate-ut?

It would be helpful to understand the scope first. What exactly will amd-pstate-ut
used for? Based on the patch series it looked like:

-- amd-pstate-ut has unit test code which will be triggered from kselftest

This is perfectly fine. The driver can reside under drivers/cpufreq and a test.sh
can reside under selftests. It can just use kselftest framework.

Based on what you are saying. kselftest might be a good choice.

thanks,
-- Shuah