linux-kernel - Re: [PATCH v3 08/11] smp: replace smp_call_function_many_cond() with __smp_call_mask

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 04:09:54 +0800
From:   kernel test robot <lkp@...el.com>
To:     Donghai Qiao <dqiao@...hat.com>, akpm@...ux-foundation.org,
        sfr@...b.auug.org.au, arnd@...db.de, peterz@...radead.org,
        heying24@...wei.com, andriy.shevchenko@...ux.intel.com,
        axboe@...nel.dk, rdunlap@...radead.org, tglx@...utronix.de,
        gor@...ux.ibm.com
Cc:     kbuild-all@...ts.01.org, donghai.w.qiao@...il.com,
        linux-kernel@...r.kernel.org, Donghai Qiao <dqiao@...hat.com>
Subject: Re: [PATCH v3 08/11] smp: replace smp_call_function_many_cond() with
 __smp_call_mask_cond()

Hi Donghai,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on linus/master v5.18-rc7]
[cannot apply to tip/x86/core powerpc/next next-20220518]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Donghai-Qiao/smp-cross-CPU-call-interface/20220518-020728
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
config: parisc-defconfig (https://download.01.org/0day-ci/archive/20220519/202205190420.dnidcWc5-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/84d80dd2d0311a0de7a50290032cb79c13151af1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Donghai-Qiao/smp-cross-CPU-call-interface/20220518-020728
        git checkout 84d80dd2d0311a0de7a50290032cb79c13151af1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=parisc SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   arch/parisc/mm/init.c: In function 'pagetable_init':
   arch/parisc/mm/init.c:623:31: warning: variable 'end_paddr' set but not used [-Wunused-but-set-variable]
     623 |                 unsigned long end_paddr;
         |                               ^~~~~~~~~
   arch/parisc/mm/init.c: In function 'flush_tlb_all':
>> arch/parisc/mm/init.c:850:32: error: 'lush_tlb_all_local' undeclared (first use in this function); did you mean 'flush_tlb_all_local'?
     850 |         smp_call(SMP_CALL_ALL, lush_tlb_all_local, NULL, SMP_CALL_TYPE_SYNC);
         |                                ^~~~~~~~~~~~~~~~~~
         |                                flush_tlb_all_local
   arch/parisc/mm/init.c:850:32: note: each undeclared identifier is reported only once for each function it appears in


vim +850 arch/parisc/mm/init.c

   835	
   836	void flush_tlb_all(void)
   837	{
   838		int do_recycle;
   839	
   840		do_recycle = 0;
   841		spin_lock(&sid_lock);
   842		__inc_irq_stat(irq_tlb_count);
   843		if (dirty_space_ids > RECYCLE_THRESHOLD) {
   844		    BUG_ON(recycle_inuse);  /* FIXME: Use a semaphore/wait queue here */
   845		    get_dirty_sids(&recycle_ndirty,recycle_dirty_array);
   846		    recycle_inuse++;
   847		    do_recycle++;
   848		}
   849		spin_unlock(&sid_lock);
 > 850		smp_call(SMP_CALL_ALL, lush_tlb_all_local, NULL, SMP_CALL_TYPE_SYNC);

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp