[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9e9a687e-3c72-fdf9-eb64-6be7b60b9706@linuxfoundation.org>
Date: Wed, 18 May 2022 16:59:02 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Kees Cook <keescook@...omium.org>,
David Howells <dhowells@...hat.com>
Cc: David Woodhouse <dwmw2@...radead.org>,
Eric Biggers <ebiggers@...nel.org>,
Salvatore Bonaccorso <carnil@...ian.org>,
keyrings@...r.kernel.org, Adam Langley <agl@...gle.com>,
Lee Jones <lee.jones@...aro.org>, linux-kernel@...r.kernel.org,
linux-hardening@...r.kernel.org,
Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] sign-file: Convert API usage to support OpenSSL v3
On 5/18/22 3:51 PM, Kees Cook wrote:
> OpenSSL's ENGINE API is deprecated in OpenSSL v3.0, along with some
> other functions. Remove the ENGINE use and a macro work-around for
> ERR_get_error_line().
>
> Cc: David Howells <dhowells@...hat.com>
> Cc: David Woodhouse <dwmw2@...radead.org>
> Cc: Eric Biggers <ebiggers@...nel.org>
> Cc: Shuah Khan <skhan@...uxfoundation.org>
> Cc: Salvatore Bonaccorso <carnil@...ian.org>
> Cc: keyrings@...r.kernel.org
> Suggested-by: Adam Langley <agl@...gle.com>
> Co-developed-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Lee Jones <lee.jones@...aro.org>
> Signed-off-by: Kees Cook <keescook@...omium.org>
> ---
> v1: https://lore.kernel.org/lkml/20211005161833.1522737-1-lee.jones@linaro.org/
> v2: https://lore.kernel.org/lkml/Yicwb+Ceiu8JjVIS@google.com/
> v3:
> - Eliminate all the build warnings with OpenSSL 3
> - Fully remove ENGINE usage, if it can be optional, just drop it.
> ---
> scripts/sign-file.c | 49 ++++++++++-----------------------------------
> 1 file changed, 11 insertions(+), 38 deletions(-)
Worked for me on OpenSSL v3 and older version .
Tested-by: Shuah Khan <skhan@...uxfoundation.org>
thanks,
-- Shuah
Powered by blists - more mailing lists