| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 May 2022 13:03:16 +0800
From: kernel test robot <lkp@...el.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [jlayton:ceph-netfs-llist 47/51] fs/netfs/buffered_read.c:51:41:
warning: variable 'caching' set but not used
tree: https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git ceph-netfs-llist
head: 33ef80e1351d57c7496e3dfb6974767f4493dd91
commit: 9d12233e09a18b8beb5206a8a2a4b67e8dcc1163 [47/51] netfs: don't mark destination pages dirty after read op
config: m68k-allmodconfig (https://download.01.org/0day-ci/archive/20220518/202205181302.jLGZzh6l-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git/commit/?id=9d12233e09a18b8beb5206a8a2a4b67e8dcc1163
git remote add jlayton https://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux.git
git fetch --no-tags jlayton ceph-netfs-llist
git checkout 9d12233e09a18b8beb5206a8a2a4b67e8dcc1163
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash fs/netfs/
If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>
All warnings (new ones prefixed by >>):
fs/netfs/buffered_read.c: In function 'netfs_rreq_unlock_folios':
>> fs/netfs/buffered_read.c:51:41: warning: variable 'caching' set but not used [-Wunused-but-set-variable]
51 | bool pg_failed = false, caching = false;
| ^~~~~~~
vim +/caching +51 fs/netfs/buffered_read.c
16211268fcb366 David Howells 2022-03-01 11
16211268fcb366 David Howells 2022-03-01 12 /*
16211268fcb366 David Howells 2022-03-01 13 * Unlock the folios in a read operation. We need to set PG_fscache on any
16211268fcb366 David Howells 2022-03-01 14 * folios we're going to write back before we unlock them.
16211268fcb366 David Howells 2022-03-01 15 */
16211268fcb366 David Howells 2022-03-01 16 void netfs_rreq_unlock_folios(struct netfs_io_request *rreq)
16211268fcb366 David Howells 2022-03-01 17 {
16211268fcb366 David Howells 2022-03-01 18 struct netfs_io_subrequest *subreq;
16211268fcb366 David Howells 2022-03-01 19 struct folio *folio;
16211268fcb366 David Howells 2022-03-01 20 unsigned int iopos, account = 0;
16211268fcb366 David Howells 2022-03-01 21 pgoff_t start_page = rreq->start / PAGE_SIZE;
16211268fcb366 David Howells 2022-03-01 22 pgoff_t last_page = ((rreq->start + rreq->len) / PAGE_SIZE) - 1;
16211268fcb366 David Howells 2022-03-01 23 bool subreq_failed = false;
16211268fcb366 David Howells 2022-03-01 24
16211268fcb366 David Howells 2022-03-01 25 XA_STATE(xas, &rreq->mapping->i_pages, start_page);
16211268fcb366 David Howells 2022-03-01 26
16211268fcb366 David Howells 2022-03-01 27 if (test_bit(NETFS_RREQ_FAILED, &rreq->flags)) {
16211268fcb366 David Howells 2022-03-01 28 __clear_bit(NETFS_RREQ_COPY_TO_CACHE, &rreq->flags);
16211268fcb366 David Howells 2022-03-01 29 list_for_each_entry(subreq, &rreq->subrequests, rreq_link) {
16211268fcb366 David Howells 2022-03-01 30 __clear_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags);
16211268fcb366 David Howells 2022-03-01 31 }
16211268fcb366 David Howells 2022-03-01 32 }
16211268fcb366 David Howells 2022-03-01 33
16211268fcb366 David Howells 2022-03-01 34 /* Walk through the pagecache and the I/O request lists simultaneously.
16211268fcb366 David Howells 2022-03-01 35 * We may have a mixture of cached and uncached sections and we only
16211268fcb366 David Howells 2022-03-01 36 * really want to write out the uncached sections. This is slightly
16211268fcb366 David Howells 2022-03-01 37 * complicated by the possibility that we might have huge pages with a
16211268fcb366 David Howells 2022-03-01 38 * mixture inside.
16211268fcb366 David Howells 2022-03-01 39 */
16211268fcb366 David Howells 2022-03-01 40 subreq = list_first_entry(&rreq->subrequests,
16211268fcb366 David Howells 2022-03-01 41 struct netfs_io_subrequest, rreq_link);
16211268fcb366 David Howells 2022-03-01 42 iopos = 0;
16211268fcb366 David Howells 2022-03-01 43 subreq_failed = (subreq->error < 0);
16211268fcb366 David Howells 2022-03-01 44
16211268fcb366 David Howells 2022-03-01 45 trace_netfs_rreq(rreq, netfs_rreq_trace_unlock);
16211268fcb366 David Howells 2022-03-01 46
16211268fcb366 David Howells 2022-03-01 47 rcu_read_lock();
16211268fcb366 David Howells 2022-03-01 48 xas_for_each(&xas, folio, last_page) {
16211268fcb366 David Howells 2022-03-01 49 unsigned int pgpos = (folio_index(folio) - start_page) * PAGE_SIZE;
16211268fcb366 David Howells 2022-03-01 50 unsigned int pgend = pgpos + folio_size(folio);
6a2bc74cfa2f46 David Howells 2021-07-07 @51 bool pg_failed = false, caching = false;
16211268fcb366 David Howells 2022-03-01 52
16211268fcb366 David Howells 2022-03-01 53 for (;;) {
16211268fcb366 David Howells 2022-03-01 54 if (!subreq) {
16211268fcb366 David Howells 2022-03-01 55 pg_failed = true;
16211268fcb366 David Howells 2022-03-01 56 break;
16211268fcb366 David Howells 2022-03-01 57 }
6a2bc74cfa2f46 David Howells 2021-07-07 58 caching = test_bit(NETFS_SREQ_COPY_TO_CACHE, &subreq->flags);
16211268fcb366 David Howells 2022-03-01 59 pg_failed |= subreq_failed;
16211268fcb366 David Howells 2022-03-01 60 if (pgend < iopos + subreq->len)
16211268fcb366 David Howells 2022-03-01 61 break;
16211268fcb366 David Howells 2022-03-01 62
16211268fcb366 David Howells 2022-03-01 63 account += subreq->transferred;
16211268fcb366 David Howells 2022-03-01 64 iopos += subreq->len;
16211268fcb366 David Howells 2022-03-01 65 if (!list_is_last(&subreq->rreq_link, &rreq->subrequests)) {
16211268fcb366 David Howells 2022-03-01 66 subreq = list_next_entry(subreq, rreq_link);
16211268fcb366 David Howells 2022-03-01 67 subreq_failed = (subreq->error < 0);
16211268fcb366 David Howells 2022-03-01 68 } else {
16211268fcb366 David Howells 2022-03-01 69 subreq = NULL;
16211268fcb366 David Howells 2022-03-01 70 subreq_failed = false;
16211268fcb366 David Howells 2022-03-01 71 }
16211268fcb366 David Howells 2022-03-01 72 if (pgend == iopos)
16211268fcb366 David Howells 2022-03-01 73 break;
16211268fcb366 David Howells 2022-03-01 74 }
16211268fcb366 David Howells 2022-03-01 75
16211268fcb366 David Howells 2022-03-01 76 if (!pg_failed) {
16211268fcb366 David Howells 2022-03-01 77 flush_dcache_folio(folio);
16211268fcb366 David Howells 2022-03-01 78 folio_mark_uptodate(folio);
9d12233e09a18b Jeff Layton 2022-05-17 79 #if 0
6a2bc74cfa2f46 David Howells 2021-07-07 80 if (caching)
6a2bc74cfa2f46 David Howells 2021-07-07 81 folio_mark_dirty(folio);
9d12233e09a18b Jeff Layton 2022-05-17 82 #endif
16211268fcb366 David Howells 2022-03-01 83 }
16211268fcb366 David Howells 2022-03-01 84
16211268fcb366 David Howells 2022-03-01 85 if (!test_bit(NETFS_RREQ_DONT_UNLOCK_FOLIOS, &rreq->flags)) {
16211268fcb366 David Howells 2022-03-01 86 if (folio_index(folio) == rreq->no_unlock_folio &&
16211268fcb366 David Howells 2022-03-01 87 test_bit(NETFS_RREQ_NO_UNLOCK_FOLIO, &rreq->flags))
16211268fcb366 David Howells 2022-03-01 88 _debug("no unlock");
16211268fcb366 David Howells 2022-03-01 89 else
16211268fcb366 David Howells 2022-03-01 90 folio_unlock(folio);
16211268fcb366 David Howells 2022-03-01 91 }
16211268fcb366 David Howells 2022-03-01 92 }
16211268fcb366 David Howells 2022-03-01 93 rcu_read_unlock();
16211268fcb366 David Howells 2022-03-01 94
16211268fcb366 David Howells 2022-03-01 95 task_io_account_read(account);
16211268fcb366 David Howells 2022-03-01 96 if (rreq->netfs_ops->done)
16211268fcb366 David Howells 2022-03-01 97 rreq->netfs_ops->done(rreq);
16211268fcb366 David Howells 2022-03-01 98 }
16211268fcb366 David Howells 2022-03-01 99
:::::: The code at line 51 was first introduced by commit
:::::: 6a2bc74cfa2f46d146438e369ae93ba2bc25a714 netfs: Do copy-to-cache-on-read through VM writeback
:::::: TO: David Howells <dhowells@...hat.com>
:::::: CC: Jeff Layton <jlayton@...nel.org>
--
0-DAY CI Kernel Test Service
https://01.org/lkp
Powered by blists - more mailing lists