linux-kernel - Re: [PATCH] ARM: mstar: Fix refcount leaks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABgxDoK-0r+LYbTfV3jHh986rw63J2HZ8_gKZ-hodZdnV6NSPQ@mail.gmail.com>
Date:   Wed, 18 May 2022 08:29:07 +0200
From:   Romain Perier <romain.perier@...il.com>
To:     Miaoqian Lin <linmq006@...il.com>
Cc:     Daniel Palmer <daniel@...ngy.jp>,
        Russell King <linux@...linux.org.uk>,
        Arnd Bergmann <arnd@...db.de>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ARM: mstar: Fix refcount leaks

Hi,

Le jeu. 12 mai 2022 à 05:47, Miaoqian Lin <linmq006@...il.com> a écrit :
>
> of_find_compatible_node() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: 5919eec0f092 ("ARM: mstar: SMP support")
> Fixes: 312b62b6610c ("ARM: mstar: Add machine for MStar/Sigmastar Armv7 SoCs")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

Looks good to me,

Reviewed-by: Romain Perier <romain.perier@...il.com>