linux-kernel - Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bdfca03d-66e7-44b4-0c79-d0558437e432@suse.com>
Date:   Wed, 18 May 2022 08:51:23 +0200
From:   Juergen Gross <jgross@...e.com>
To:     Josh Poimboeuf <jpoimboe@...nel.org>,
        Maximilian Heyne <mheyne@...zon.de>
Cc:     Boris Ostrovsky <boris.ostrovsky@...cle.com>,
        Stefano Stabellini <sstabellini@...nel.org>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>, Borislav Petkov <bp@...en8.de>,
        Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>, xen-devel@...ts.xenproject.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86: xen: remove STACK_FRAME_NON_STANDARD from xen_cpuid

On 17.05.22 18:42, Josh Poimboeuf wrote:
> On Tue, May 17, 2022 at 04:24:25PM +0000, Maximilian Heyne wrote:
>> Since commit 4d65adfcd119 ("x86: xen: insn: Decode Xen and KVM
>> emulate-prefix signature"), objtool is able to correctly parse the
>> prefixed instruction in xen_cpuid and emit correct orc unwind
>> information. Hence, marking the function as STACKFRAME_NON_STANDARD is
>> no longer needed.
>>
>> This commit is basically a revert of commit 983bb6d254c7 ("x86/xen: Mark
>> xen_cpuid() stack frame as non-standard").
>>
>> Signed-off-by: Maximilian Heyne <mheyne@...zon.de>
>> CC: Josh Poimboeuf <jpoimboe@...nel.org>
>>
>> cr: https://code.amazon.com/reviews/CR-69645080
>        ^^^^^
> 
> This looks like an internal amazon link and should be removed.
> Otherwise, looks good to me.

Can be done while committing.

Reviewed-by: Juergen Gross <jgross@...e.com>


Juergen

Download attachment "OpenPGP_0xB0DE9DD628BF132F.asc" of type "application/pgp-keys" (3099 bytes)

Download attachment "OpenPGP_signature" of type "application/pgp-signature" (492 bytes)