linux-kernel - Re: [PATCH 1/2] platform/chrome: Use tables for values lists of ChromeOS ACPI sysfs ABI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoSd6NQBvX41y7Fb@google.com>
Date:   Wed, 18 May 2022 15:19:04 +0800
From:   Tzung-Bi Shih <tzungbi@...nel.org>
To:     Bagas Sanjaya <bagasdotme@...il.com>
Cc:     linux-doc@...r.kernel.org, Stephen Rothwell <sfr@...b.auug.org.au>,
        Benson Leung <bleung@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Enric Balletbo i Serra <enric.balletbo@...labora.com>,
        Muhammad Usama Anjum <usama.anjum@...labora.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH 1/2] platform/chrome: Use tables for values lists of
 ChromeOS ACPI sysfs ABI

On Wed, May 18, 2022 at 01:50:26PM +0700, Bagas Sanjaya wrote:
> On 5/18/22 10:37, Tzung-Bi Shih wrote:
> > On Wed, May 18, 2022 at 10:17:50AM +0700, Bagas Sanjaya wrote:
> >>  What:		/sys/bus/platform/devices/GGL0001:*/CHSW
> >>  Date:		May 2022
> >>  KernelVersion:	5.19
> >>  Description:
> >>  		This file shows the switch position for the Chrome OS specific
> >> -		hardware switches.
> >> -		  * 0   - No changes.
> >> -		  * 2   - Recovery button was pressed when firmware booted.
> >> -		  * 4   - Recovery button was pressed when EC firmware booted.
> >> -		  * 32  - Developer switch was enabled when firmware booted.
> >> -		  * 512 - Firmware write protection was disabled when firmware
> >> -			  booted.
> >> +		hardware switches when the firmare is booted.
> > 
> > s/firmare/firmware/.
> > 
> > Could you fix it in v2 and also Cc to <chrome-platform@...ts.linux.dev>?
> 
> OK, but regarding the schedule, we are on -rc7 (official mainline release
> will be imminent). Maybe I can send the v2 immediately, or should I wait
> for a day?

I think either way is fine.  The patch introduced the sphinx warning is still
in chrome-platform's for-next branch[1].  And it should send to mainline when 
the next merge window opens.

[1]: https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git/commit/?h=for-next&id=0a4cad9c11ad46662ede48d94f08ecb7cd9f6916