linux-kernel - Re: [PATCH] cpu/hotplug: check the return value of idle_thread

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87leuzjk3a.ffs@tglx>
Date:   Wed, 18 May 2022 10:55:37 +0200
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Chao Liu <liuchao173@...wei.com>, linux-kernel@...r.kernel.org,
        hewenliang4@...wei.com
Cc:     steven.price@....com, Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH] cpu/hotplug: check the return value of idle_thread_get

On Mon, Mar 27 2023 at 20:37, Chao Liu wrote:
> ilde may be ERR_PTR()

Yes, but if that happens in bringup_cpu() or finish_cpu() it would be a
serious bug and the error pointer dereference would be the least of the
problems.

If the initial check in _cpu_up() failed for a CPU then the above
functions cannot be invoked for that CPU ever.

Thanks,

        tglx