linux-kernel - Re: [PATCH v2 1/2] pinctrl: intel: make irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Wed, 18 May 2022 12:19:14 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Shevchenko <andy@...nel.org>,
        Linus Walleij <linus.walleij@...aro.org>
Subject: Re: [PATCH v2 1/2] pinctrl: intel: make irq_chip immutable

On Wed, May 18, 2022 at 11:46:06AM +0300, Andy Shevchenko wrote:
> On Wed, May 18, 2022 at 08:08:17AM +0300, Mika Westerberg wrote:
> > On Tue, May 17, 2022 at 07:38:19PM +0300, Andy Shevchenko wrote:
> > > +static const struct irq_chip intel_gpio_irq_chip = {
> > > +	.name		= "intel-gpio",
> > > +	.irq_ack	= intel_gpio_irq_ack,
> > > +	.irq_mask	= intel_gpio_irq_mask,
> > > +	.irq_unmask	= intel_gpio_irq_unmask,
> > > +	.irq_set_type	= intel_gpio_irq_type,
> > > +	.irq_set_wake	= intel_gpio_irq_wake,
> > > +	.flags		= IRQCHIP_MASK_ON_SUSPEND | IRQCHIP_IMMUTABLE,
> > > +	GPIOCHIP_IRQ_RESOURCE_HELPERS,
> > > +};
> > 
> > You still have the inconsistent alignment here.
> 
> I'm not sure what problem do you see.

I mean the tab alignment you use:

	.name		= "intel-gpio",
	.irq_ack	= intel_gpio_irq_ack,
	.irq_mask	= intel_gpio_irq_mask,
	.irq_unmask	= intel_gpio_irq_unmask,
	.irq_set_type	= intel_gpio_irq_type,
	.irq_set_wake	= intel_gpio_irq_wake,

All the other struct initializations in the driver use this style (and I
prefer it too):

	.name = "intel-gpio",
	.irq_ack = intel_gpio_irq_ack,
	.irq_mask = intel_gpio_irq_mask,
	.irq_unmask = intel_gpio_irq_unmask,
	.irq_set_type = intel_gpio_irq_type,
	.irq_set_wake = intel_gpio_irq_wake,

Hope this explains.