[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1761ab1a-68ce-4946-24d4-8f4f9575e735@xs4all.nl>
Date: Wed, 18 May 2022 11:54:17 +0200
From: Hans Verkuil <hverkuil@...all.nl>
To: Guo Zhengkui <guozhengkui@...o.com>,
Andrzej Pietrasiewicz <andrzejtp2010@...il.com>,
Jacek Anaszewski <jacek.anaszewski@...il.com>,
Sylwester Nawrocki <s.nawrocki@...sung.com>,
Mauro Carvalho Chehab <mchehab@...nel.org>,
"moderated list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT"
<linux-arm-kernel@...ts.infradead.org>,
"open list:ARM/SAMSUNG S5P SERIES JPEG CODEC SUPPORT"
<linux-media@...r.kernel.org>,
open list <linux-kernel@...r.kernel.org>
Cc: zhengkui_guo@...look.com
Subject: Re: [PATCH] media: platform: replace ternary operator with max()
Hi Guo Zhengkui,
Please mention the driver in the subject line! Saying 'media: platform:' suggests
changes throughout many media/platform drivers, but this is just for a single
driver.
Regards,
Hans
On 5/13/22 15:32, Guo Zhengkui wrote:
> Fix the following coccicheck warning:
>
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c:1712:24-25:
> WARNING opportunity for max()
>
> max() macro is defined in include/linux/minmax.h. It avoids multiple
> evaluations of the arguments when non-constant and performs strict
> type-checking.
>
> Signed-off-by: Guo Zhengkui <guozhengkui@...o.com>
> ---
> drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> index 456287186ad8..55814041b8d8 100644
> --- a/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> +++ b/drivers/media/platform/samsung/s5p-jpeg/jpeg-core.c
> @@ -1709,7 +1709,7 @@ static int exynos3250_jpeg_try_downscale(struct s5p_jpeg_ctx *ctx,
> w_ratio = ctx->out_q.w / r->width;
> h_ratio = ctx->out_q.h / r->height;
>
> - scale_factor = w_ratio > h_ratio ? w_ratio : h_ratio;
> + scale_factor = max(w_ratio, h_ratio);
> scale_factor = clamp_val(scale_factor, 1, 8);
>
> /* Align scale ratio to the nearest power of 2 */
Powered by blists - more mailing lists