linux-kernel - [netfilter-nf-next:testing 8/11] net/netfilter/nf_hook_bpf.c:378:18: warning: no previous prototype for 'nf_hook_bpf_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:   Wed, 18 May 2022 18:08:52 +0800
From:   kernel test robot <lkp@...el.com>
To:     Florian Westphal <fw@...len.de>
Cc:     kbuild-all@...ts.01.org, linux-kernel@...r.kernel.org
Subject: [netfilter-nf-next:testing 8/11] net/netfilter/nf_hook_bpf.c:378:18:
 warning: no previous prototype for 'nf_hook_bpf_create_fb'

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git testing
head:   d8a22b0067851629c08b1094c3341b4058758041
commit: c80ff016f9fc9439c07633f45e4567bb8b098657 [8/11] netfilter: add bpf base hook program generator
config: powerpc-allmodconfig (https://download.01.org/0day-ci/archive/20220518/202205181839.Zgp0r4lh-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git/commit/?id=c80ff016f9fc9439c07633f45e4567bb8b098657
        git remote add netfilter-nf-next git://git.kernel.org/pub/scm/linux/kernel/git/netfilter/nf-next.git
        git fetch --no-tags netfilter-nf-next testing
        git checkout c80ff016f9fc9439c07633f45e4567bb8b098657
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=powerpc SHELL=/bin/bash net/netfilter/

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

>> net/netfilter/nf_hook_bpf.c:378:18: warning: no previous prototype for 'nf_hook_bpf_create_fb' [-Wmissing-prototypes]
     378 | struct bpf_prog *nf_hook_bpf_create_fb(void)
         |                  ^~~~~~~~~~~~~~~~~~~~~
>> net/netfilter/nf_hook_bpf.c:400:18: warning: no previous prototype for 'nf_hook_bpf_create' [-Wmissing-prototypes]
     400 | struct bpf_prog *nf_hook_bpf_create(const struct nf_hook_entries *new)
         |                  ^~~~~~~~~~~~~~~~~~
>> net/netfilter/nf_hook_bpf.c:420:6: warning: no previous prototype for 'nf_hook_bpf_change_prog' [-Wmissing-prototypes]
     420 | void nf_hook_bpf_change_prog(struct bpf_dispatcher *d, struct bpf_prog *from, struct bpf_prog *to)
         |      ^~~~~~~~~~~~~~~~~~~~~~~


vim +/nf_hook_bpf_create_fb +378 net/netfilter/nf_hook_bpf.c

   372	
   373	/* fallback program, invokes nf_hook_slow interpreter.
   374	 *
   375	 * Used when a hook is unregsitered and new program cannot
   376	 * be compiled for some reason.
   377	 */
 > 378	struct bpf_prog *nf_hook_bpf_create_fb(void)
   379	{
   380		struct bpf_prog *prog;
   381		struct nf_hook_prog p;
   382		int err;
   383	
   384		err = nf_hook_prog_init(&p);
   385		if (err)
   386			return NULL;
   387	
   388		if (!do_prologue(&p))
   389			goto err;
   390	
   391		if (!emit_nf_hook_slow(&p))
   392			goto err;
   393	
   394		prog = nf_hook_jit_compile(p.insns, p.pos);
   395	err:
   396		nf_hook_prog_free(&p);
   397		return prog;
   398	}
   399	
 > 400	struct bpf_prog *nf_hook_bpf_create(const struct nf_hook_entries *new)
   401	{
   402		struct bpf_prog *prog;
   403		struct nf_hook_prog p;
   404		int err;
   405	
   406		err = nf_hook_prog_init(&p);
   407		if (err)
   408			return NULL;
   409	
   410		err = xlate_base_hooks(&p, new);
   411		if (err)
   412			goto err;
   413	
   414		prog = nf_hook_jit_compile(p.insns, p.pos);
   415	err:
   416		nf_hook_prog_free(&p);
   417		return prog;
   418	}
   419	
 > 420	void nf_hook_bpf_change_prog(struct bpf_dispatcher *d, struct bpf_prog *from, struct bpf_prog *to)

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp