[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <YoRLcfSC//FZn1UI@google.com>
Date: Wed, 18 May 2022 01:27:13 +0000
From: Carlos Llamas <cmllamas@...gle.com>
To: Schspa Shi <schspa@...il.com>
Cc: gregkh@...uxfoundation.org, arve@...roid.com, tkjos@...roid.com,
maco@...roid.com, joel@...lfernandes.org, brauner@...nel.org,
hridya@...gle.com, surenb@...gle.com, linux-kernel@...r.kernel.org,
syzbot+46fff6434a7f968ecb39@...kaller.appspotmail.com
Subject: Re: [PATCH v2] binder: fix atomic sleep when get extended error
On Wed, May 18, 2022 at 09:17:54AM +0800, Schspa Shi wrote:
> binder_inner_proc_lock(thread->proc) is a spin lock, copy_to_user can't
> be called with in this lock.
>
> Copy it as a local variable to fix it.
>
> Reported-by: syzbot+46fff6434a7f968ecb39@...kaller.appspotmail.com
> Fixes: bd32889e841c ("binder: add BINDER_GET_EXTENDED_ERROR ioctl")
> Signed-off-by: Schspa Shi <schspa@...il.com>
>
> ---
>
> Changelog:
> v1 -> v2:
> - Remove the retry as Carlos Llamas adviced.
> - Use binder_set_extended_error to reset the error info.
> ---
LGTM, thanks.
Reviewed-by: Carlos Llamas <cmllamas@...gle.com>
--
Carlos Llamas
Powered by blists - more mailing lists