linux-kernel - Re: [PATCH v2 2/2] platform/chrome: Use imperative mood for ChromeOS ACPI sysfs ABI descriptions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <890ae132-cf86-8c82-8280-291869183f5f@collabora.com>
Date:   Wed, 18 May 2022 16:27:35 +0500
From:   Muhammad Usama Anjum <usama.anjum@...labora.com>
To:     Bagas Sanjaya <bagasdotme@...il.com>, linux-doc@...r.kernel.org
Cc:     usama.anjum@...labora.com, Benson Leung <bleung@...gle.com>,
        Guenter Roeck <groeck@...omium.org>,
        Andy Shevchenko <andy.shevchenko@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Rafael J . Wysocki" <rafael.j.wysocki@...el.com>,
        Dmitry Torokhov <dmitry.torokhov@...il.com>,
        Tzung-Bi Shih <tzungbi@...nel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Linux Next Mailing List <linux-next@...r.kernel.org>
Subject: Re: [PATCH v2 2/2] platform/chrome: Use imperative mood for ChromeOS
 ACPI sysfs ABI descriptions

On 5/18/22 1:35 PM, Bagas Sanjaya wrote:
> The current descriptions all begin with ("This file shows something")
> clause, which is incorrect wording since these mean return value from
> sysfs.
> 
> Use imperative mood ("Returns something") instead, in line with
> corresponding ACPI documentation at firmware-guide/.
> 
> Cc: Benson Leung <bleung@...gle.com>
> Cc: Guenter Roeck <groeck@...omium.org>
> Cc: Andy Shevchenko <andy.shevchenko@...il.com>
> Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> Cc: Rafael J. Wysocki <rafael.j.wysocki@...el.com>
> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>
> Cc: Enric Balletbo i Serra <enric.balletbo@...labora.com>
> Cc: Muhammad Usama Anjum <usama.anjum@...labora.com>
> Cc: Tzung-Bi Shih <tzungbi@...nel.org>
> Cc: Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
> Cc: Linux Next Mailing List <linux-next@...r.kernel.org>
> Signed-off-by: Bagas Sanjaya <bagasdotme@...il.com>

Reviewed-by: Muhammad Usama Anjum <usama.anjum@...labora.com>

-- 
Muhammad Usama Anjum