lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 18 May 2022 14:33:15 +0300 From: Vladimir Oltean <olteanv@...il.com> To: Martin Blumenstingl <martin.blumenstingl@...glemail.com> Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org, andrew@...n.ch, vivien.didelot@...il.com, f.fainelli@...il.com, davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, Hauke Mehrtens <hauke@...ke-m.de> Subject: Re: [PATCH net v1 2/2] net: dsa: lantiq_gswip: Fix typo in gswip_port_fdb_dump() error print On Tue, May 17, 2022 at 09:40:15PM +0200, Martin Blumenstingl wrote: > gswip_port_fdb_dump() reads the MAC bridge entries. The error message > should say "failed to read mac bridge entry". While here, also add the > index to the error print so humans can get to the cause of the problem > easier. > > Fixes: 58c59ef9e930c4 ("net: dsa: lantiq: Add Forwarding Database access") > Acked-by: Hauke Mehrtens <hauke@...ke-m.de> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@...glemail.com> > --- Reviewed-by: Vladimir Oltean <olteanv@...il.com> > drivers/net/dsa/lantiq_gswip.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/dsa/lantiq_gswip.c b/drivers/net/dsa/lantiq_gswip.c > index 0c313db23451..8af4def38a98 100644 > --- a/drivers/net/dsa/lantiq_gswip.c > +++ b/drivers/net/dsa/lantiq_gswip.c > @@ -1426,8 +1426,9 @@ static int gswip_port_fdb_dump(struct dsa_switch *ds, int port, > > err = gswip_pce_table_entry_read(priv, &mac_bridge); > if (err) { > - dev_err(priv->dev, "failed to write mac bridge: %d\n", > - err); > + dev_err(priv->dev, > + "failed to read mac bridge entry %d: %d\n", > + i, err); > return err; > } > > -- > 2.36.1 >
Powered by blists - more mailing lists