linux-kernel - [PATCH 2/2] ext4: rename temporary variables in ext4_finish

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220518120137.2544-2-liupeibao@163.com>
Date:   Wed, 18 May 2022 20:01:37 +0800
From:   Liu Peibao <liupeibao@....com>
To:     tytso@....edu, adilger.kernel@...ger.ca
Cc:     linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
        liupeibao@....com
Subject: [PATCH 2/2] ext4: rename temporary variables in ext4_finish_bio()

The temporary variable bio_start and bio_end are confusingly
misnamed. Rename them with bvec_ instead of bio_ to indicate
what they really are.

Signed-off-by: Liu Peibao <liupeibao@....com>
---
 fs/ext4/page-io.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c
index fd55e11c8391..dd0a7f734d7f 100644
--- a/fs/ext4/page-io.c
+++ b/fs/ext4/page-io.c
@@ -106,8 +106,8 @@ static void ext4_finish_bio(struct bio *bio)
 		struct page *page = bvec->bv_page;
 		struct page *bounce_page = NULL;
 		struct buffer_head *bh, *head;
-		unsigned int bio_start = bvec->bv_offset;
-		unsigned int bio_end = bio_start + bvec->bv_len;
+		unsigned int bvec_start = bvec->bv_offset;
+		unsigned int bvec_end = bvec_start + bvec->bv_len;
 		unsigned int under_io = 0;
 		unsigned long flags;
 
@@ -127,8 +127,8 @@ static void ext4_finish_bio(struct bio *bio)
 		 */
 		spin_lock_irqsave(&head->b_uptodate_lock, flags);
 		do {
-			if (bh_offset(bh) < bio_start ||
-			    bh_offset(bh) + bh->b_size > bio_end) {
+			if (bh_offset(bh) < bvec_start ||
+			    bh_offset(bh) + bh->b_size > bvec_end) {
 				if (buffer_async_write(bh))
 					under_io++;
 				continue;
-- 
2.20.1