linux-kernel - Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3c5532e-c8f1-791d-6c58-ccd1c426432@linux.intel.com>
Date:   Wed, 18 May 2022 15:25:07 +0300 (EEST)
From:   Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To:     Shubhrajyoti Datta <shubhrajyoti.datta@...il.com>
cc:     linux-serial <linux-serial@...r.kernel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        Jiri Slaby <jirislaby@...nel.org>,
        Peter Korsgaard <jacmet@...site.dk>,
        Sean Anderson <sean.anderson@...o.com>,
        linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/9] serial: uartline: Fix BRKINT clearing

On Wed, 18 May 2022, Shubhrajyoti Datta wrote:

> On Tue, May 17, 2022 at 5:58 PM Ilpo Järvinen
> <ilpo.jarvinen@...ux.intel.com> wrote:
> >
> > BRKINT is within c_iflag rather than c_cflag.
> Nit typo in the subject line.

Indeed, good catch. Even after you pointed it out, it was still hard to 
spot what was wrong with it.

Thanks.

-- 
 i.

> > Cc: Sean Anderson <sean.anderson@...o.com>
> > Fixes: ea017f5853e9 (tty: serial: uartlite: Prevent changing fixed parameters)
> > Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> > ---
> >  drivers/tty/serial/uartlite.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/tty/serial/uartlite.c b/drivers/tty/serial/uartlite.c
> > index 007db67292a2..880e2afbb97b 100644
> > --- a/drivers/tty/serial/uartlite.c
> > +++ b/drivers/tty/serial/uartlite.c
> > @@ -321,7 +321,8 @@ static void ulite_set_termios(struct uart_port *port, struct ktermios *termios,
> >         struct uartlite_data *pdata = port->private_data;
> >
> >         /* Set termios to what the hardware supports */
> > -       termios->c_cflag &= ~(BRKINT | CSTOPB | PARENB | PARODD | CSIZE);
> > +       termios->c_iflag &= ~BRKINT;
> > +       termios->c_cflag &= ~(CSTOPB | PARENB | PARODD | CSIZE);
> >         termios->c_cflag |= pdata->cflags & (PARENB | PARODD | CSIZE);
> >         tty_termios_encode_baud_rate(termios, pdata->baud, pdata->baud);
> >
> > --
> > 2.30.2
> >
>