linux-kernel - Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings for Renesas RZ/N1 Advanced 5 port switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220518144111.135c7d0d@fixe.home>
Date:   Wed, 18 May 2022 14:41:11 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Rob Herring <robh@...nel.org>, Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Herve Codina <herve.codina@...tlin.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        Milan Stevanovic <milan.stevanovic@...com>,
        Jimmy Lalande <jimmy.lalande@...com>,
        Pascal Eberhard <pascal.eberhard@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH net-next v4 05/12] dt-bindings: net: dsa: add bindings
 for Renesas RZ/N1 Advanced 5 port switch

Le Wed, 18 May 2022 15:05:03 +0300,
Vladimir Oltean <olteanv@...il.com> a écrit :

> On Tue, May 17, 2022 at 08:59:24PM -0500, Rob Herring wrote:
> > On Wed, May 11, 2022 at 06:33:37PM +0300, Vladimir Oltean wrote:  
> > > On Wed, May 11, 2022 at 10:22:21AM -0500, Rob Herring wrote:  
> > > > > +patternProperties:
> > > > > +  "^ethernet-ports$":  
> > > > 
> > > > Move to 'properties', not a pattern.
> > > > 
> > > > With that,
> > > > 
> > > > Reviewed-by: Rob Herring <robh@...nel.org>  
> > > 
> > > Even if it should have been "^(ethernet-)?ports$"?  
> > 
> > Why? Allowing 'ports' is for existing users. New ones don't need the 
> > variability and should use just 'ethernet-ports'.
> > 
> > Rob  
> 
> Yeah, ok, somehow the memo that new DSA drivers shouldn't support "ports"
> didn't reach me. They invariably will though, since the DSA framework is
> the main parser of the property, and that is shared by both old and new
> drivers.

Should also the subnodes of "ethernet-ports" use the
"ethernet-port@[0-9]*" naming ? Or keeping the existing pattern is ok
(ie "^(ethernet-)?port@[0-4]$") ?

Thanks,

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com