linux-kernel - Re: [PATCH v0] nfc: pn533: Fix buggy cleanup order

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <165287881144.21214.2658320019255160778.git-patchwork-notify@kernel.org>
Date:   Wed, 18 May 2022 13:00:11 +0000
From:   patchwork-bot+netdevbpf@...nel.org
To:     Lin Ma <linma@....edu.cn>
Cc:     krzysztof.kozlowski@...aro.org, dan.carpenter@...cle.com,
        cyeaa@...nect.ust.hk, rikard.falkeborn@...il.com,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v0] nfc: pn533: Fix buggy cleanup order

Hello:

This patch was applied to netdev/net.git (master)
by David S. Miller <davem@...emloft.net>:

On Wed, 18 May 2022 18:53:21 +0800 you wrote:
> When removing the pn533 device (i2c or USB), there is a logic error. The
> original code first cancels the worker (flush_delayed_work) and then
> destroys the workqueue (destroy_workqueue), leaving the timer the last
> one to be deleted (del_timer). This result in a possible race condition
> in a multi-core preempt-able kernel. That is, if the cleanup
> (pn53x_common_clean) is concurrently run with the timer handler
> (pn533_listen_mode_timer), the timer can queue the poll_work to the
> already destroyed workqueue, causing use-after-free.
> 
> [...]

Here is the summary with links:
  - [v0] nfc: pn533: Fix buggy cleanup order
    https://git.kernel.org/netdev/net/c/b8cedb7093b2

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html