linux-kernel - Re: [PATCH] gcc: fix -Warray-compare

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 17 May 2022 18:50:35 -0700
From:   Jakub Kicinski <kuba@...nel.org>
To:     Martin Liška <mliska@...e.cz>
Cc:     netdev@...r.kernel.org, lkml <linux-kernel@...r.kernel.org>,
        davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com
Subject: Re: [PATCH] gcc: fix -Warray-compare

On Tue, 17 May 2022 16:19:16 +0200 Martin Liška wrote:
> Subject: [PATCH] gcc: fix -Warray-compare

The subject should be more like

eth: sun: cassini: remove dead code

> 
> Fixes the following GCC warning:
> 
> drivers/net/ethernet/sun/cassini.c:1316:29: error: comparison between two arrays [-Werror=array-compare]
> drivers/net/ethernet/sun/cassini.c:3783:34: error: comparison between two arrays [-Werror=array-compare]

Because AFAICT this comparison will always be true:

#define CAS_HP_ALT_FIRMWARE   cas_prog_null

Hopefully DaveM will correct if I'm getting this wrong :)