linux-kernel - Re: [PATCH] driver core: location: Free struct acpi_pld

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <YoZ1oY7/lhUjcs04@kroah.com>
Date:   Thu, 19 May 2022 18:51:45 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Won Chung <wonchung@...gle.com>
Cc:     Yu Watanabe <watanabe.yu@...il.com>, linux-kernel@...r.kernel.org,
        "Rafael J . Wysocki" <rafael@...nel.org>
Subject: Re: [PATCH] driver core: location: Free struct acpi_pld_info *pld

On Thu, May 19, 2022 at 06:51:13PM +0200, Greg Kroah-Hartman wrote:
> On Mon, May 09, 2022 at 05:31:35PM +0000, Won Chung wrote:
> > After struct acpi_pld_info *pld is used to fill in physical location
> > values, it should be freed to prevent memleak.
> > 
> > Suggested-by: Yu Watanabe <watanabe.yu@...il.com>
> > Signed-off-by: Won Chung <wonchung@...gle.com>
> > ---
> >  drivers/base/physical_location.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/base/physical_location.c b/drivers/base/physical_location.c
> > index fbd9f9839e92..617ada542b00 100644
> > --- a/drivers/base/physical_location.c
> > +++ b/drivers/base/physical_location.c
> > @@ -32,6 +32,7 @@ bool dev_add_physical_location(struct device *dev)
> >  	dev->physical_location->dock = pld->dock;
> >  	dev->physical_location->lid = pld->lid;
> >  
> > +	ACPI_FREE(pld);
> >  	return true;
> >  }
> >  
> > -- 
> > 2.36.0.512.ge40c2bad7a-goog
> > 
> 
> What commit id does this fix?  Please add that and resend.
> 
> thanks,
> greg k-h

Nevermind, I'll take it as-is.