linux-kernel - Re: [PATCH] platform/x86/intel/ifs: Add CPU_SUP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dacd535a-eb99-fcf7-5859-639d54f22612@redhat.com>
Date:   Thu, 19 May 2022 19:47:50 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     Randy Dunlap <rdunlap@...radead.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        X86 ML <x86@...nel.org>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH] platform/x86/intel/ifs: Add CPU_SUP_INTEL dependency

Hi,

On 5/19/22 16:57, Borislav Petkov wrote:
> From: Borislav Petkov <bp@...e.de>
> 
> The driver is using functions from a compilation unit which is enabled
> by CONFIG_CPU_SUP_INTEL. Add that dependency to Kconfig explicitly
> otherwise:
> 
>   drivers/platform/x86/intel/ifs/load.o: in function `ifs_load_firmware':
>   load.c:(.text+0x3b8): undefined reference to `intel_cpu_collect_info'
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>
> Signed-off-by: Borislav Petkov <bp@...e.de>

Thank you for your patch, I've applied this patch to my review-hans 
branch:
https://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86.git/log/?h=review-hans

Note it will show up in my review-hans branch once I've pushed my
local branch there, which might take a while.

Once I've run some tests on this branch the patches there will be
added to the platform-drivers-x86/for-next branch and eventually
will be included in the pdx86 pull-request to Linus for the next
merge-window.

Regards,

Hans


> ---
>  drivers/platform/x86/intel/ifs/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/platform/x86/intel/ifs/Kconfig b/drivers/platform/x86/intel/ifs/Kconfig
> index d84491cfb0db..7ce896434b8f 100644
> --- a/drivers/platform/x86/intel/ifs/Kconfig
> +++ b/drivers/platform/x86/intel/ifs/Kconfig
> @@ -1,6 +1,6 @@
>  config INTEL_IFS
>  	tristate "Intel In Field Scan"
> -	depends on X86 && 64BIT && SMP
> +	depends on X86 && CPU_SUP_INTEL && 64BIT && SMP
>  	select INTEL_IFS_DEVICE
>  	help
>  	  Enable support for the In Field Scan capability in select