lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Message-ID: <202205200352.WNFV7NdM-lkp@intel.com>
Date:   Fri, 20 May 2022 03:29:46 +0800
From:   kernel test robot <lkp@...el.com>
To:     Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
Cc:     llvm@...ts.linux.dev, kbuild-all@...ts.01.org,
        linux-kernel@...r.kernel.org
Subject: fs/ntfs3/fsntfs.c:770:5: warning: stack frame size (2112) exceeds
 limit (1024) in 'ntfs_clear_mft_tail'

Hi Konstantin,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b015dcd62b86d298829990f8261d5d154b8d7af5
commit: 6e5be40d32fb1907285277c02e74493ed43d77fe fs/ntfs3: Add NTFS3 in fs/Kconfig and fs/Makefile
date:   9 months ago
config: hexagon-randconfig-r011-20220519 (https://download.01.org/0day-ci/archive/20220520/202205200352.WNFV7NdM-lkp@intel.com/config)
compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project e00cbbec06c08dc616a0d52a20f678b8fbd4e304)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=6e5be40d32fb1907285277c02e74493ed43d77fe
        git remote add linus https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
        git fetch --no-tags linus master
        git checkout 6e5be40d32fb1907285277c02e74493ed43d77fe
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=hexagon SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All warnings (new ones prefixed by >>):

   fs/ntfs3/fsntfs.c:1874:9: warning: variable 'cnt' set but not used [-Wunused-but-set-variable]
           size_t cnt, off;
                  ^
>> fs/ntfs3/fsntfs.c:770:5: warning: stack frame size (2112) exceeds limit (1024) in 'ntfs_clear_mft_tail' [-Wframe-larger-than]
   int ntfs_clear_mft_tail(struct ntfs_sb_info *sbi, size_t from, size_t to)
       ^
   2 warnings generated.


vim +/ntfs_clear_mft_tail +770 fs/ntfs3/fsntfs.c

82cae269cfa953 Konstantin Komarov 2021-08-13  763  
82cae269cfa953 Konstantin Komarov 2021-08-13  764  /*
82cae269cfa953 Konstantin Komarov 2021-08-13  765   * ntfs_clear_mft_tail
82cae269cfa953 Konstantin Komarov 2021-08-13  766   *
82cae269cfa953 Konstantin Komarov 2021-08-13  767   * formats empty records [from, to)
82cae269cfa953 Konstantin Komarov 2021-08-13  768   * sbi->mft.bitmap is locked for write
82cae269cfa953 Konstantin Komarov 2021-08-13  769   */
82cae269cfa953 Konstantin Komarov 2021-08-13 @770  int ntfs_clear_mft_tail(struct ntfs_sb_info *sbi, size_t from, size_t to)
82cae269cfa953 Konstantin Komarov 2021-08-13  771  {
82cae269cfa953 Konstantin Komarov 2021-08-13  772  	int err;
82cae269cfa953 Konstantin Komarov 2021-08-13  773  	u32 rs;
82cae269cfa953 Konstantin Komarov 2021-08-13  774  	u64 vbo;
82cae269cfa953 Konstantin Komarov 2021-08-13  775  	struct runs_tree *run;
82cae269cfa953 Konstantin Komarov 2021-08-13  776  	struct ntfs_inode *ni;
82cae269cfa953 Konstantin Komarov 2021-08-13  777  
82cae269cfa953 Konstantin Komarov 2021-08-13  778  	if (from >= to)
82cae269cfa953 Konstantin Komarov 2021-08-13  779  		return 0;
82cae269cfa953 Konstantin Komarov 2021-08-13  780  
82cae269cfa953 Konstantin Komarov 2021-08-13  781  	rs = sbi->record_size;
82cae269cfa953 Konstantin Komarov 2021-08-13  782  	ni = sbi->mft.ni;
82cae269cfa953 Konstantin Komarov 2021-08-13  783  	run = &ni->file.run;
82cae269cfa953 Konstantin Komarov 2021-08-13  784  
82cae269cfa953 Konstantin Komarov 2021-08-13  785  	down_read(&ni->file.run_lock);
82cae269cfa953 Konstantin Komarov 2021-08-13  786  	vbo = (u64)from * rs;
82cae269cfa953 Konstantin Komarov 2021-08-13  787  	for (; from < to; from++, vbo += rs) {
82cae269cfa953 Konstantin Komarov 2021-08-13  788  		struct ntfs_buffers nb;
82cae269cfa953 Konstantin Komarov 2021-08-13  789  
82cae269cfa953 Konstantin Komarov 2021-08-13  790  		err = ntfs_get_bh(sbi, run, vbo, rs, &nb);
82cae269cfa953 Konstantin Komarov 2021-08-13  791  		if (err)
82cae269cfa953 Konstantin Komarov 2021-08-13  792  			goto out;
82cae269cfa953 Konstantin Komarov 2021-08-13  793  
82cae269cfa953 Konstantin Komarov 2021-08-13  794  		err = ntfs_write_bh(sbi, &sbi->new_rec->rhdr, &nb, 0);
82cae269cfa953 Konstantin Komarov 2021-08-13  795  		nb_put(&nb);
82cae269cfa953 Konstantin Komarov 2021-08-13  796  		if (err)
82cae269cfa953 Konstantin Komarov 2021-08-13  797  			goto out;
82cae269cfa953 Konstantin Komarov 2021-08-13  798  	}
82cae269cfa953 Konstantin Komarov 2021-08-13  799  
82cae269cfa953 Konstantin Komarov 2021-08-13  800  out:
82cae269cfa953 Konstantin Komarov 2021-08-13  801  	sbi->mft.used = from;
82cae269cfa953 Konstantin Komarov 2021-08-13  802  	up_read(&ni->file.run_lock);
82cae269cfa953 Konstantin Komarov 2021-08-13  803  	return err;
82cae269cfa953 Konstantin Komarov 2021-08-13  804  }
82cae269cfa953 Konstantin Komarov 2021-08-13  805  

:::::: The code at line 770 was first introduced by commit
:::::: 82cae269cfa953032fbb8980a7d554d60fb00b17 fs/ntfs3: Add initialization of super block

:::::: TO: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>
:::::: CC: Konstantin Komarov <almaz.alexandrovich@...agon-software.com>

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ