linux-kernel - Re: [PATCH v3 0/3] Add ASPEED AST2600 I2C new controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DDAAA045-3BDE-4712-A6CC-B1A52713634A@fb.com>
Date:   Thu, 19 May 2022 19:56:24 +0000
From:   Peter Delevoryas <pdel@...com>
To:     unlisted-recipients:; (no To-header on input)
CC:     Joel Stanley <joel@....id.au>, Andrew Jeffery <andrew@...id.au>,
        Philipp Zabel <p.zabel@...gutronix.de>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-aspeed@...ts.ozlabs.org" <linux-aspeed@...ts.ozlabs.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        OpenBMC List <openbmc@...ts.ozlabs.org>,
        "BMC-SW@...eedtech.com" <BMC-SW@...eedtech.com>,
        Peter Delevoryas <pdel@...com>,
        "ryan_chen@...eedtech.com" <ryan_chen@...eedtech.com>
Subject: Re: [PATCH v3 0/3] Add ASPEED AST2600 I2C new controller driver



> On May 15, 2022, at 11:48 PM, ryan_chen <ryan_chen@...eedtech.com> wrote:
> 
> This series add AST2600 i2c new register set driver. The i2c new
> register set have new clock divider option for more flexiable generation.
> And also have separate i2c master and slave register set for control.

Hey Ryan, thanks for this work! This is a little bit off-topic,
but are you or anyone else at Aspeed working on an equivalent QEMU
patch series? Without it, I don’t think QEMU will work with this
series right? I think QEMU only supports the old register set right now.

Thanks,
Peter

> 
> v3:
> -fix i2c global clock divide default value
> -remove i2c slave no used dev_dbg info.
> 
> v2:
> -add i2c global ymal file commit
> -rename file name from new to ast2600.
> aspeed-i2c-new-global.c -> i2c-ast2600-global.c
> aspeed-i2c-new-global.h -> i2c-ast2600-global.h
> i2c-new-aspeed.c -> i2c-ast2600.c
> -rename all driver function name to ast2600
> 
> ryan_chen (3):
>  dt-bindings: i2c-ast2600: Add bindings for AST2600 i2C global register
>    controller
>  dt-bindings: i2c-ast2600: Add bindings for AST2600 i2C driver
>  i2c:aspeed:support ast2600 i2c new register mode driver
> 
> .../i2c/aspeed,i2c-ast2600-global.ymal        |   44 +
> .../bindings/i2c/aspeed,i2c-ast2600.ymal      |   78 +
> drivers/i2c/busses/Kconfig                    |   11 +
> drivers/i2c/busses/Makefile                   |    1 +
> drivers/i2c/busses/i2c-ast2600-global.c       |   94 +
> drivers/i2c/busses/i2c-ast2600-global.h       |   19 +
> drivers/i2c/busses/i2c-ast2600.c              | 1703 +++++++++++++++++
> 7 files changed, 1950 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600-global.ymal
> create mode 100644 Documentation/devicetree/bindings/i2c/aspeed,i2c-ast2600.ymal
> create mode 100644 drivers/i2c/busses/i2c-ast2600-global.c
> create mode 100644 drivers/i2c/busses/i2c-ast2600-global.h
> create mode 100644 drivers/i2c/busses/i2c-ast2600.c
> 
> -- 
> 2.17.1
> 
>