linux-kernel - Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally be const

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Yoaj9baQHs9gZpz5@smile.fi.intel.com>
Date:   Thu, 19 May 2022 23:09:25 +0300
From:   Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To:     Uri Arev <me@...tyapps.xyz>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Len Baker <len.baker@....com>, Sam Ravnborg <sam@...nborg.org>,
        Thomas Zimmermann <tzimmermann@...e.de>,
        Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>,
        Srivathsa Dara <srivathsa729.8@...il.com>,
        Noralf Trønnes <noralf@...nnes.org>,
        dri-devel@...ts.freedesktop.org, linux-fbdev@...r.kernel.org,
        linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: fbtft: fix checkpatch.pl struct should normally
 be const

On Thu, May 19, 2022 at 08:25:01PM +0300, Uri Arev wrote:
> This simple patch fixes a checkpatch.pl warning in `fbtft/fbtft-core.c`.
> 
> Reported by Checkpatch:
> WARNING: struct fb_ops should normally be const

...

> -	fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL);
> +	const fbops = devm_kzalloc(dev, sizeof(struct fb_ops), GFP_KERNEL);

Why?

-- 
With Best Regards,
Andy Shevchenko