linux-kernel - Re: [PATCH v2 07/28] lib/printbuf: Unit specifiers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220519202626.3x3kyqs3jttel7u4@moria.home.lan>
Date:   Thu, 19 May 2022 16:26:26 -0400
From:   Kent Overstreet <kent.overstreet@...il.com>
To:     Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:     linux-kernel@...r.kernel.org, linux-mm@...r.kernel.org,
        pmladek@...e.com, rostedt@...dmis.org, senozhatsky@...omium.org,
        willy@...radead.org
Subject: Re: [PATCH v2 07/28] lib/printbuf: Unit specifiers

On Thu, May 19, 2022 at 11:21:41PM +0300, Andy Shevchenko wrote:
> On Thu, May 19, 2022 at 01:24:00PM -0400, Kent Overstreet wrote:
> > +void pr_human_readable_s64(struct printbuf *buf, s64 v)
> > +{
> > +	if (v < 0)
> > +		pr_char(buf, '-');
> > +	pr_human_readable_u64(buf, abs(v));
> 
> Wouldn't -v work?

This is a bit terser

> > + * pr_human_readable_u64 - Print out a u64 according to printbuf unit options
> 
> Have you ever compile this? We have kernel doc validator running when compiling
> the code...

Yes I have, but I've never seen the kernel doc validator - can you point me to
something so I can get that working?

> > +void pr_units_s64(struct printbuf *out, s64 v)
> > +{
> > +	if (v < 0)
> > +		pr_char(out, '-');
> > +	pr_units_u64(out, v);
> 
> Please, start with test cases.

I suppose now that we've got kunit I should learn how to use it :) And thanks,
good catch