linux-kernel - Re: [PATCH 2/8] firmware: qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20220519000350.DD5C0C385A9@smtp.kernel.org>
Date:   Wed, 18 May 2022 17:03:49 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Mathieu Poirier <mathieu.poirier@...aro.org>,
        Michael Turquette <mturquette@...libre.com>,
        linux-arm-msm@...r.kernel.org, linux-clk@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-remoteproc@...r.kernel.org
Cc:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH 2/8] firmware: qcom_scm-legacy: correct kerneldoc

Quoting Krzysztof Kozlowski (2022-05-01 03:35:14)
> diff --git a/drivers/firmware/qcom_scm-legacy.c b/drivers/firmware/qcom_scm-legacy.c
> index 1829ba220576..7854af4abc62 100644
> --- a/drivers/firmware/qcom_scm-legacy.c
> +++ b/drivers/firmware/qcom_scm-legacy.c
> @@ -120,6 +120,9 @@ static void __scm_legacy_do(const struct arm_smccc_args *smc,
>  /**
>   * scm_legacy_call() - Sends a command to the SCM and waits for the command to
>   * finish processing.
> + * @dev:       device
> + * @desc:      descriptor structure containing arguments and return values
> + * @res:        results from SMC/HVC call

I think only SMC call is possible so drop HVC to not be confusing.

>   *
>   * A note on cache maintenance:
>   * Note that any buffers that are expected to be accessed by the secure world