linux-kernel - Re: [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20220519083440.luyv6lzcq3fiw27e@sgarzare-redhat>
Date:   Thu, 19 May 2022 10:34:40 +0200
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Jason Wang <jasowang@...hat.com>
Cc:     mst@...hat.com, virtualization@...ts.linux-foundation.org,
        linux-kernel@...r.kernel.org, tglx@...utronix.de,
        peterz@...radead.org, paulmck@...nel.org, maz@...nel.org,
        pasic@...ux.ibm.com, cohuck@...hat.com, eperezma@...hat.com,
        lulu@...hat.com, xuanzhuo@...ux.alibaba.com,
        Vineeth Vijayan <vneethv@...ux.ibm.com>,
        Peter Oberparleiter <oberpar@...ux.ibm.com>,
        linux-s390@...r.kernel.org
Subject: Re: [PATCH V5 9/9] virtio: use WARN_ON() to warn illegal status value

On Wed, May 18, 2022 at 11:59:51AM +0800, Jason Wang wrote:
>We used to use BUG_ON() in virtio_device_ready() to detect illegal
>status value, this seems sub-optimal since the value is under the
>control of the device. Switch to use WARN_ON() instead.
>
>Cc: Thomas Gleixner <tglx@...utronix.de>
>Cc: Peter Zijlstra <peterz@...radead.org>
>Cc: "Paul E. McKenney" <paulmck@...nel.org>
>Cc: Marc Zyngier <maz@...nel.org>
>Cc: Halil Pasic <pasic@...ux.ibm.com>
>Cc: Cornelia Huck <cohuck@...hat.com>
>Cc: Vineeth Vijayan <vneethv@...ux.ibm.com>
>Cc: Peter Oberparleiter <oberpar@...ux.ibm.com>
>Cc: linux-s390@...r.kernel.org
>Signed-off-by: Jason Wang <jasowang@...hat.com>
>---
> include/linux/virtio_config.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>