linux-kernel - Re: [PATCH] video: fbdev: Fix refcount leak in clcdfb_of_vram

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3976cf6a-0b40-4763-a233-eacf93925d53@gmx.de>
Date:   Thu, 19 May 2022 11:14:01 +0200
From:   Helge Deller <deller@....de>
To:     Miaoqian Lin <linmq006@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Pawel Moll <pawel.moll@....com>,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] video: fbdev: Fix refcount leak in clcdfb_of_vram_setup

On 5/12/22 13:59, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when not need anymore.
> Add missing of_node_put() to avoid refcount leak.
>
> Fixes: d10715be03bd ("video: ARM CLCD: Add DT support")
> Signed-off-by: Miaoqian Lin <linmq006@...il.com>

applied to the fbdev tree.
Thanks!
Helge

> ---
>  drivers/video/fbdev/amba-clcd.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/video/fbdev/amba-clcd.c b/drivers/video/fbdev/amba-clcd.c
> index 9ec969e136bf..8080116aea84 100644
> --- a/drivers/video/fbdev/amba-clcd.c
> +++ b/drivers/video/fbdev/amba-clcd.c
> @@ -758,12 +758,15 @@ static int clcdfb_of_vram_setup(struct clcd_fb *fb)
>  		return -ENODEV;
>
>  	fb->fb.screen_base = of_iomap(memory, 0);
> -	if (!fb->fb.screen_base)
> +	if (!fb->fb.screen_base) {
> +		of_node_put(memory);
>  		return -ENOMEM;
> +	}
>
>  	fb->fb.fix.smem_start = of_translate_address(memory,
>  			of_get_address(memory, 0, &size, NULL));
>  	fb->fb.fix.smem_len = size;
> +	of_node_put(memory);
>
>  	return 0;
>  }