linux-kernel - Re: [PATCH] omapfb: simplify the return expression of dsi_init_pll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 11:20:04 +0200
From:   Helge Deller <deller@....de>
To:     cgel.zte@...il.com
Cc:     linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        Minghao Chi <chi.minghao@....com.cn>,
        Zeal Robot <zealci@....com.cn>
Subject: Re: [PATCH] omapfb: simplify the return expression of
 dsi_init_pll_data()

On 4/29/22 07:47, cgel.zte@...il.com wrote:
> From: Minghao Chi <chi.minghao@....com.cn>
>
> Simplify the return expression.
>
> Reported-by: Zeal Robot <zealci@....com.cn>
> Signed-off-by: Minghao Chi <chi.minghao@....com.cn>

I've applied both of your omapfb patches to the fbdev tree.

Thanks!
Helge


> ---
>  drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c | 8 +-------
>  1 file changed, 1 insertion(+), 7 deletions(-)
>
> diff --git a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> index c5f89129dcdd..531b36d2232b 100644
> --- a/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> +++ b/drivers/video/fbdev/omap2/omapfb/dss/hdmi_pll.c
> @@ -173,7 +173,6 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data
>  {
>  	struct dss_pll *pll = &hpll->pll;
>  	struct clk *clk;
> -	int r;
>
>  	clk = devm_clk_get(&pdev->dev, "sys_clk");
>  	if (IS_ERR(clk)) {
> @@ -203,12 +202,7 @@ static int dsi_init_pll_data(struct platform_device *pdev, struct hdmi_pll_data
>  	}
>
>  	pll->ops = &dsi_pll_ops;
> -
> -	r = dss_pll_register(pll);
> -	if (r)
> -		return r;
> -
> -	return 0;
> +	return dss_pll_register(pll);
>  }
>
>  int hdmi_pll_init(struct platform_device *pdev, struct hdmi_pll_data *pll,