linux-kernel - Re: [PATCH] rtc: ftrtc010: Fix error handling in ftrtc010_rtc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 12:11:51 +0200
From:   Alexandre Belloni <alexandre.belloni@...tlin.com>
To:     linux-arm-kernel@...ts.infradead.org, linux-rtc@...r.kernel.org,
        linux-kernel@...r.kernel.org, Miaoqian Lin <linmq006@...il.com>,
        Linus Walleij <linus.walleij@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Hans Ulli Kroll <ulli.kroll@...glemail.com>
Subject: Re: [PATCH] rtc: ftrtc010: Fix error handling in ftrtc010_rtc_probe

On Sun, 3 Apr 2022 05:49:12 +0000, Miaoqian Lin wrote:
> In the error handling path, the clk_prepare_enable() function
> call should be balanced by a corresponding 'clk_disable_unprepare()'
> call , as already done in the remove function.
> 
> clk_disable_unprepare calls clk_disable() and clk_unprepare().
> They will use IS_ERR_OR_NULL to check the argument.
> 
> [...]

Applied, thanks!

[1/1] rtc: ftrtc010: Fix error handling in ftrtc010_rtc_probe
      commit: b520cbe5be37b1b9b401c0b6ecbdae32575273db

Best regards,

-- 
Alexandre Belloni, co-owner and COO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com