linux-kernel - Re: [PATCH] USB / image: Fix spacing issues in mdc800_endpoint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 19 May 2022 12:34:10 +0200
From:   Greg KH <gregkh@...uxfoundation.org>
To:     Kushagra Verma <kushagra765@...look.com>
Cc:     linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] USB / image: Fix spacing issues in
 mdc800_endpoint_equals()

On Thu, May 19, 2022 at 02:42:31PM +0530, Kushagra Verma wrote:
> This patch fixes the following spacing issues in mdc800_endpoint_equals():
> 	1. (Removed) Space between function name and opening parenthesis.
> 	2. (Removed) Space between variable and opening and closing
>             parenthesis in the return statement.
> 	3. (Added) Space between 2 function arguments.
> 
> This fixes multiple checkpatch warnings for this function.
> 
> Signed-off-by: Kushagra Verma <kushagra765@...look.com>
> ---
>  drivers/usb/image/mdc800.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/usb/image/mdc800.c b/drivers/usb/image/mdc800.c
> index fc0e22cc6fda..dc03e0e54fe0 100644
> --- a/drivers/usb/image/mdc800.c
> +++ b/drivers/usb/image/mdc800.c
> @@ -220,12 +220,12 @@ static struct mdc800_data* mdc800;
>  	The USB Part of the driver
>  ****************************************************************************/
>  
> -static int mdc800_endpoint_equals (struct usb_endpoint_descriptor *a,struct usb_endpoint_descriptor *b)
> +static int mdc800_endpoint_equals(struct usb_endpoint_descriptor *a, struct usb_endpoint_descriptor *b)
>  {
>  	return (
> -		   ( a->bEndpointAddress == b->bEndpointAddress )
> -		&& ( a->bmAttributes     == b->bmAttributes     )
> -		&& ( a->wMaxPacketSize   == b->wMaxPacketSize   )
> +		   (a->bEndpointAddress == b->bEndpointAddress)
> +		&& (a->bmAttributes     == b->bmAttributes)
> +		&& (a->wMaxPacketSize   == b->wMaxPacketSize)

As you can see, the original alignments was done for the specific reason
of making this "pretty".  Your changes really do not help anything here,
which is the primary reason to make checkpatch cleanup changes.

So I'll leave this alone, sorry.

thanks,

greg k-h