linux-kernel - Re: [PATCH v4 6/6] arm64: dts: qcom: Add PMP8074 DTSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4d9b29e8-b171-e181-e2a7-2c8c80107ab1@linaro.org>
Date:   Thu, 19 May 2022 13:35:30 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Robert Marko <robimarko@...il.com>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        lgirdwood@...il.com, broonie@...nel.org,
        Rob Herring <robh+dt@...nel.org>,
        krzysztof.kozlowski+dt@...aro.org,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>,
        Devicetree List <devicetree@...r.kernel.org>,
        Konrad Dybcio <konrad.dybcio@...ainline.org>
Subject: Re: [PATCH v4 6/6] arm64: dts: qcom: Add PMP8074 DTSI

On 19/05/2022 13:21, Robert Marko wrote:
> On Thu, 19 May 2022 at 13:07, Krzysztof Kozlowski
> <krzysztof.kozlowski@...aro.org> wrote:
>>
>> On 18/05/2022 20:48, Robert Marko wrote:
>>> PMP8074 is a companion PMIC to the Qualcomm IPQ8074 series that is
>>> controlled via SPMI.
>>>
>>> Since we now have support for the regulators inside of it add DTSI
>>> for it.
>>>
>>> Signed-off-by: Robert Marko <robimarko@...il.com>
>>> ---
>>>  arch/arm64/boot/dts/qcom/pmp8074.dtsi | 38 +++++++++++++++++++++++++++
>>
>> This file is not referenced by anything, thus not possible to compile
>> nor verify.
> 
> That is correct, I can include it on HK01 which has an SDHCI controller
> and thus can consume L11 for VQMMC so that HS200 and higher work.

Yes, otherwise this does not have any effect.

> 
> I wanted to include the nodes directly in the SoC DTSI and set L11 as VQMMC
> for SDHCI there as this is a companion PMIC and always present, but
> the established
> procedure is for the PMIC to have its own DTSI and then be included per board.

Which was correct suggestion but it is not relevant here. In your
previous approach your PMIC would be included on every board via SoC
DTSI. Now your PMIC is not included at all.


Best regards,
Krzysztof