linux-kernel - Re: [PATCH net-next v4 06/12] net: dsa: rzn1-a5psw: add Renesas RZ/N1 advanced 5 port switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20220519160353.12ee7463@fixe.home>
Date:   Thu, 19 May 2022 16:03:53 +0200
From:   Clément Léger <clement.leger@...tlin.com>
To:     Vladimir Oltean <olteanv@...il.com>
Cc:     Andrew Lunn <andrew@...n.ch>,
        Vivien Didelot <vivien.didelot@...il.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        "David S . Miller" <davem@...emloft.net>,
        Eric Dumazet <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>,
        Paolo Abeni <pabeni@...hat.com>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Magnus Damm <magnus.damm@...il.com>,
        Heiner Kallweit <hkallweit1@...il.com>,
        Russell King <linux@...linux.org.uk>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
        Herve Codina <herve.codina@...tlin.com>,
        Miquèl Raynal <miquel.raynal@...tlin.com>,
        Milan Stevanovic <milan.stevanovic@...com>,
        Jimmy Lalande <jimmy.lalande@...com>,
        Pascal Eberhard <pascal.eberhard@...com>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
        linux-renesas-soc@...r.kernel.org, netdev@...r.kernel.org,
        Jean-Pierre Geslin <jean-pierre.geslin@....se.com>,
        Phil Edworthy <phil.edworthy@...esas.com>
Subject: Re: [PATCH net-next v4 06/12] net: dsa: rzn1-a5psw: add Renesas
 RZ/N1 advanced 5 port switch driver

Le Wed, 11 May 2022 12:36:38 +0300,
Vladimir Oltean <olteanv@...il.com> a écrit :

> On Tue, May 10, 2022 at 10:34:58AM +0200, Clément Léger wrote:
> > > By the way, does this switch pass
> > > tools/testing/selftests/drivers/net/dsa/no_forwarding.sh?  
> > 
> > Unfortunately, the board I have only has 2 ports availables and thus, I
> > can only test one bridge or two separated ports at a time... I *should*
> > receive a 4 ports one in a near future but that not yet sure.  
> 
> 2 switch ports or 2 ports in total? h1 and h2 can be non-switch ports
> (should work with USB-Ethernet adapters etc).

Ok, I finally got the tests running. They seems to work for the
standalone variant.

TEST: Standalone switch ports: Unicast non-IP untagged              [ OK ]
TEST: Standalone switch ports: Multicast non-IP untagged            [ OK ]
TEST: Standalone switch ports: Broadcast non-IP untagged            [ OK ]
TEST: Standalone switch ports: Unicast IPv4 untagged                [ OK ]
TEST: Standalone switch ports: Multicast IPv4 untagged              [ OK ]
TEST: Standalone switch ports: Unicast IPv6 untagged                [ OK ]
TEST: Standalone switch ports: Multicast IPv6 untagged              [ OK ]

I disabled tests two_bridges and one_bridge_two_pvids since the
switch driver does only support 1 bridge and do not have vlan support
yet.

I also ran ./test_bridge_fdb_stress.sh which did reveal some sleep in
spin_lock() issue due to poll_io_timeout() being used. I switch the FDB
lock to use a mutex instead of a spinlock.

-- 
Clément Léger,
Embedded Linux and Kernel engineer at Bootlin
https://bootlin.com