linux-kernel - Re: [PATCH] usb: Probe EHCI, OHCI controllers asynchronously

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 May 2022 15:43:57 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Brian Norris <briannorris@...omium.org>
Cc:     Alan Stern <stern@...land.harvard.edu>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Dmitry Torokhov <dtor@...omium.org>,
        Linux USB List <linux-usb@...r.kernel.org>
Subject: Re: [PATCH] usb: Probe EHCI, OHCI controllers asynchronously

Hi,

On Wed, May 18, 2022 at 3:04 PM Brian Norris <briannorris@...omium.org> wrote:
>
> From: Dmitry Torokhov <dtor@...omium.org>
>
> initcall_debug shows that OHCI controllers take ~60ms to probe on
> Rockchip RK3399 systems:
>
>   probe of fe3a0000.usb returned 1 after 58941 usecs
>
> A few of these can add up to waste non-trivial amounts of time at boot.
>
> These host controllers don't provide resources to other drivers, so
> this shouldn't contribute to exposing race conditions.
>
> Chrome OS kernels have carried this patch on some systems for a while
> without issues. Similar patches have been merged for a variety of (e)MMC
> host controllers for similar reasons.
>
> Signed-off-by: Dmitry Torokhov <dtor@...omium.org>
> [Brian: rewrote commit message, refreshed, but retained dtor's original
>  authorship ]
> Signed-off-by: Brian Norris <briannorris@...omium.org>
> ---
>
>  drivers/usb/host/ehci-platform.c | 1 +
>  drivers/usb/host/ohci-platform.c | 1 +
>  2 files changed, 2 insertions(+)

Reviewed-by: Douglas Anderson <dianders@...omium.org>