[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAD=FV=Und7oTNBf8+=d9_RMQyv1v0vzh6OSGpvvPTYWtGF07MA@mail.gmail.com>
Date: Thu, 19 May 2022 17:20:31 -0700
From: Doug Anderson <dianders@...omium.org>
To: dri-devel <dri-devel@...ts.freedesktop.org>
Cc: freedreno <freedreno@...ts.freedesktop.org>,
Stephen Boyd <swboyd@...omium.org>,
"Kuogee Hsieh (QUIC)" <quic_khsieh@...cinc.com>,
Sankeerth Billakanti <quic_sbillaka@...cinc.com>,
"Abhinav Kumar (QUIC)" <quic_abhinavk@...cinc.com>,
Ville Syrjälä <ville.syrjala@...ux.intel.com>,
"Aravind Venkateswaran (QUIC)" <quic_aravindh@...cinc.com>,
Thomas Zimmermann <tzimmermann@...e.de>,
Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
Rob Clark <robdclark@...il.com>,
linux-arm-msm <linux-arm-msm@...r.kernel.org>,
Daniel Vetter <daniel@...ll.ch>,
David Airlie <airlied@...ux.ie>,
Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
Maxime Ripard <mripard@...nel.org>,
LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v3 1/2] drm/probe-helper: Add helper for drm_helper_probe_single_connector_modes()
Hi,
On Wed, May 11, 2022 at 3:58 PM Douglas Anderson <dianders@...omium.org> wrote:
>
> The drm_helper_probe_single_connector_modes() is a bit long. Let's
> break a chunk off to update and validate modes. This helps avoid one
> goto and also will allow us to more easily call the helper a second
> time in a future patch without adding looping or another goto.
>
> This change is intended to be a no-op change--just code movement.
>
> Signed-off-by: Douglas Anderson <dianders@...omium.org>
> Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>
> Reviewed-by: Thomas Zimmermann <tzimmermann@...e.de>
> ---
>
> Changes in v3:
> - Removed WARN_ON
>
> Changes in v2:
> - Two underscores for __drm_helper_update_and_validate().
> - Return err and use WARN_ON instead of returning a bool.
>
> drivers/gpu/drm/drm_probe_helper.c | 106 ++++++++++++++++-------------
> 1 file changed, 60 insertions(+), 46 deletions(-)
Pushed to drm-misc-next:
4a2a13a57b60 drm/probe-helper: Add helper for
drm_helper_probe_single_connector_modes()
Powered by blists - more mailing lists