linux-kernel - RE: [PATCH net v3] net: macb: Fix PTP one step sync support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 May 2022 05:36:10 +0000
From:   Harini Katakam <harinik@...inx.com>
To:     Paolo Abeni <pabeni@...hat.com>,
        "nicolas.ferre@...rochip.com" <nicolas.ferre@...rochip.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "richardcochran@...il.com" <richardcochran@...il.com>,
        "claudiu.beznea@...rochip.com" <claudiu.beznea@...rochip.com>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>
CC:     "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Michal Simek <michals@...inx.com>,
        "harinikatakamlinux@...il.com" <harinikatakamlinux@...il.com>,
        Radhey Shyam Pandey <radheys@...inx.com>
Subject: RE: [PATCH net v3] net: macb: Fix PTP one step sync support



> -----Original Message-----
> From: Paolo Abeni <pabeni@...hat.com>
> Sent: Thursday, May 19, 2022 11:48 PM
> To: Harini Katakam <harinik@...inx.com>; nicolas.ferre@...rochip.com;
> davem@...emloft.net; richardcochran@...il.com;
> claudiu.beznea@...rochip.com; kuba@...nel.org; edumazet@...gle.com
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; Michal Simek
> <michals@...inx.com>; harinikatakamlinux@...il.com; Radhey Shyam
> Pandey <radheys@...inx.com>
> Subject: Re: [PATCH net v3] net: macb: Fix PTP one step sync support
> 
> On Wed, 2022-05-18 at 22:37 +0530, Harini Katakam wrote:
> > PTP one step sync packets cannot have CSUM padding and insertion in SW
> > since time stamp is inserted on the fly by HW.
> > In addition, ptp4l version 3.0 and above report an error when skb
> > timestamps are reported for packets that not processed for TX TS after
> > transmission.
> > Add a helper to identify PTP one step sync and fix the above two
> > errors. Add a common mask for PTP header flag field "twoStepflag".
> > Also reset ptp OSS bit when one step is not selected.
> >
> > Fixes: ab91f0a9b5f4 ("net: macb: Add hardware PTP support")
> > Fixes: 653e92a9175e ("net: macb: add support for padding and fcs
> > computation")
> > Signed-off-by: Harini Katakam <harini.katakam@...inx.com>
> > Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@...inx.com>
> 
> I'm sorry, but I cut the -net PR to Linus too early for this, so the fix will have to
> wait for a little more (no need to repost!) and even more pause will be
> required for the net-next follow-up.
> 
> Sorry for the inconvenince,

Thanks Paolo. No problem, will wait and send net-next follow up.

Regards,
Harini