linux-kernel - Re: [PATCH v2] nvmem: brcm_nvram: check for allocation failure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 20 May 2022 09:50:24 +0300
From:   Dan Carpenter <dan.carpenter@...cle.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc:     Greg KH <gregkh@...uxfoundation.org>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org,
        Rafał Miłecki <rafal@...ecki.pl>
Subject: Re: [PATCH v2] nvmem: brcm_nvram: check for allocation failure

On Thu, May 19, 2022 at 06:03:56PM +0100, Srinivas Kandagatla wrote:
> 
> 
> On 19/05/2022 17:56, Greg KH wrote:
> > On Tue, May 10, 2022 at 10:35:40AM +0100, Srinivas Kandagatla wrote:
> > > From: Dan Carpenter <dan.carpenter@...cle.com>
> > > 
> > > Check for if the kcalloc() fails.
> > > 
> > > Cc: stable@...r.kernel.org
> > > Fixes: 299dc152721f ("nvmem: brcm_nvram: parse NVRAM content into NVMEM cells")
> > 
> > This isn't a commit in any tree that I can see, are you sure it is
> > correct?
> Looks like the commit is not correct,
> It should be
> 
> Fixes: 6e977eaa8280 ("nvmem: brcm_nvram: parse NVRAM content into NVMEM
> cells")
> 
> 
> Dan, can you send this with fix to Fixes tag?

No problem.  Done.

The problem is that Fixes tags will change if you use email instead of
git pulls.  Or maybe someone used git and did a rebase?  The point is if
you just use git everywhere and don't rebase then the hashes are
immutable.

No stress though, we figured it out.

regards,
dan carpenter