linux-kernel - Re: [PATCH] rcu-tasks: Stop RCU Tasks scanning tasks which record on dyntick-idle entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202205201526.INo2g6TS-lkp@intel.com>
Date:   Fri, 20 May 2022 15:33:43 +0800
From:   kernel test robot <lkp@...el.com>
To:     Zqiang <qiang1.zhang@...el.com>, paulmck@...nel.org,
        frederic@...nel.org
Cc:     kbuild-all@...ts.01.org, rcu@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rcu-tasks: Stop RCU Tasks scanning tasks which record on
 dyntick-idle entry

Hi Zqiang,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on paulmck-rcu/dev]
[also build test ERROR on v5.18-rc7 next-20220519]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/intel-lab-lkp/linux/commits/Zqiang/rcu-tasks-Stop-RCU-Tasks-scanning-tasks-which-record-on-dyntick-idle-entry/20220520-125904
base:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
config: m68k-defconfig (https://download.01.org/0day-ci/archive/20220520/202205201526.INo2g6TS-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 11.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/intel-lab-lkp/linux/commit/47ee19cf17eefb7dd696eabb583e5dcba4cd89e1
        git remote add linux-review https://github.com/intel-lab-lkp/linux
        git fetch --no-tags linux-review Zqiang/rcu-tasks-Stop-RCU-Tasks-scanning-tasks-which-record-on-dyntick-idle-entry/20220520-125904
        git checkout 47ee19cf17eefb7dd696eabb583e5dcba4cd89e1
        # save the config file
        mkdir build_dir && cp config build_dir/.config
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.3.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   In file included from kernel/rcu/update.c:606:
   kernel/rcu/tasks.h: In function 'task_is_on_dyntick_idle':
>> kernel/rcu/tasks.h:212:34: error: 'struct task_struct' has no member named 'rcu_tasks_idle_cpu'
     212 |                                 t->rcu_tasks_idle_cpu >= 0;
         |                                  ^~
   At top level:
   kernel/rcu/tasks.h:209:13: warning: 'task_is_on_dyntick_idle' defined but not used [-Wunused-function]
     209 | static bool task_is_on_dyntick_idle(struct task_struct *t)
         |             ^~~~~~~~~~~~~~~~~~~~~~~


vim +212 kernel/rcu/tasks.h

   208	
   209	static bool task_is_on_dyntick_idle(struct task_struct *t)
   210	{
   211		return IS_ENABLED(CONFIG_NO_HZ_FULL) && !is_idle_task(t) &&
 > 212					t->rcu_tasks_idle_cpu >= 0;
   213	}
   214	

-- 
0-DAY CI Kernel Test Service
https://01.org/lkp