lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 19 May 2022 21:41:23 -1000 From: Tejun Heo <tj@...nel.org> To: Yosry Ahmed <yosryahmed@...gle.com> Cc: Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>, Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau <kafai@...com>, Song Liu <songliubraving@...com>, Yonghong Song <yhs@...com>, John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>, Hao Luo <haoluo@...gle.com>, Zefan Li <lizefan.x@...edance.com>, Johannes Weiner <hannes@...xchg.org>, Shuah Khan <shuah@...nel.org>, Roman Gushchin <roman.gushchin@...ux.dev>, Michal Hocko <mhocko@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, David Rientjes <rientjes@...gle.com>, Greg Thelen <gthelen@...gle.com>, Shakeel Butt <shakeelb@...gle.com>, linux-kernel@...r.kernel.org, netdev@...r.kernel.org, bpf@...r.kernel.org, cgroups@...r.kernel.org Subject: Re: [PATCH bpf-next v1 3/5] bpf: Introduce cgroup iter On Fri, May 20, 2022 at 01:21:31AM +0000, Yosry Ahmed wrote: > From: Hao Luo <haoluo@...gle.com> > > Introduce a new type of iter prog: cgroup. Unlike other bpf_iter, this > iter doesn't iterate a set of kernel objects. Instead, it is supposed to > be parameterized by a cgroup id and prints only that cgroup. So one > needs to specify a target cgroup id when attaching this iter. The target > cgroup's state can be read out via a link of this iter. > > Signed-off-by: Hao Luo <haoluo@...gle.com> > Signed-off-by: Yosry Ahmed <yosryahmed@...gle.com> This could be me not understanding why it's structured this way but it keeps bothering me that this is adding a cgroup iterator which doesn't iterate cgroups. If all that's needed is extracting information from a specific cgroup, why does this need to be an iterator? e.g. why can't I use BPF_PROG_TEST_RUN which looks up the cgroup with the provided ID, flushes rstat, retrieves whatever information necessary and returns that as the result? Thanks. -- tejun
Powered by blists - more mailing lists