linux-kernel - Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87leuwr5r2.wl-tiwai@suse.de>
Date:   Fri, 20 May 2022 10:02:41 +0200
From:   Takashi Iwai <tiwai@...e.de>
To:     Vitaly Rodionov <vitalyr@...nsource.cirrus.com>
Cc:     Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
        "Mark Brown" <broonie@...nel.org>, <alsa-devel@...a-project.org>,
        <patches@...nsource.cirrus.com>, <linux-kernel@...r.kernel.org>,
        Vitaly Rodionov <vitaly.rodionov@...rus.com>
Subject: Re: [PATCH v3 04/17] ALSA: hda: cs35l41: Add initial DSP support and firmware loading

On Fri, 20 May 2022 10:00:18 +0200,
Takashi Iwai wrote:
> 
> On Thu, 19 May 2022 19:47:36 +0200,
> Vitaly Rodionov wrote:
> > 
> > From: Vitaly Rodionov <vitaly.rodionov@...rus.com>
> > 
> > This patch adds support for the CS35L41 DSP.
> > The DSP allows for extra features, such as running
> > speaker protection algorithms and hibernations.
> > 
> > To utilize these features, the driver must load
> > firmware into the DSP, as well as various tuning
> > files which allow for cusomtization for specific
> > models.
> 
> Wouldn't this sequence be required after S3/S4 resume?
> I thought cs35l41_hda_bind() is called only at the first binding.

OK, I see that the later patches in the series are about hibernation.
It might be good to mention that in this patch, though.


Takashi